Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#11898 closed Patch - Bug Fix (fixed)

Mythweb: Handle empty recommended shows gracefully

Reported by: Karl Newman <SiliconFiend@…> Owned by: Rob Smith
Priority: minor Milestone: 0.28
Component: Plugin - MythWeb Version: 0.27-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When using the Mythweb TV "Recommended Programs" page, it throws a SQL error if your account on the recommendation website has no programs (that is, if you haven't indicated any preference to any show/actor/genre yet). The cause is the $extra_query argument to load_all_program_data--the formatting in modules/tv/recommended.php causes it to send "()" if $query is empty, which leads to a SQL SELECT clause containing "AND ()" which is invalid. This patch checks the string length of $query and if it's empty, sends 'FALSE' instead, which should appropriately load no programs.

Attachments (1)

mythweb_recommended.patch (452 bytes) - added by Karl Newman <SiliconFiend@…> 6 years ago.
Graceful fix for empty recommendation list

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Karl Newman <SiliconFiend@…>

Attachment: mythweb_recommended.patch added

Graceful fix for empty recommendation list

comment:1 Changed 5 years ago by Rob Smith

Resolution: Won't Fix
Status: newclosed

Given Mythweb is EOL, I'm closing new features. This should be done via the backend webserver now.

comment:2 Changed 5 years ago by Rob Smith

Resolution: Won't Fix
Status: closednew

comment:3 Changed 5 years ago by Rob Smith <kormoc@…>

Resolution: fixed
Status: newclosed

In e63850ce20374712c888ba6311e564437a2d16fa/mythweb:

Fixes #11898, this merges a patch by Karl Newman to fix the empty recommendations page

comment:4 Changed 5 years ago by paulh

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.