Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#11907 closed Bug Report - General (fixed)

vimeo doesn't work with mythnetvision

Reported by: superm1@… Owned by: Jonatan Lindblad
Priority: minor Milestone: 0.27.6
Component: Plugin - MythNetvision Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The 2 part Vimeo API key is precompiled for python 2.6. It's stored in the tree at: https://github.com/MythTV/mythtv/blob/master/mythtv/programs/scripts/internetcontent/nv_python_libs/vimeo/vimeo_data.pyc

Unfortunately, current distributions don't ship python 2.6 and this precompiled python data is unusable.

Examining other projects that use a 2 part API key, they do just leave it in the "open": https://github.com/HenrikDK/vimeo-xbmc-plugin/blob/46c9f695e97528f08878e355f7a5cdb8116beb87/plugin/vimeo/__init__.py

I raised the question with the original author Doug Vaughan.

His response: "Mario, I don't really care. Vimeo was the only one that was paranoid about their API key. I thought it was a bit over the top at the time and still do. If XBMC is leaving theirs in the clear then why not Mythtv? Even the Google API end user agreement did not have that kind of stipulation.

Do as you see fit, the code change would be minor any event.

Doug "

Discussion in IRC about this: http://irc.mythtv.org/ircLog/channel/4/2013-10-08:21:50:00/2013-10-08:22:09:00

Consequently I have a pull request to pull in the actual source file including the obfuscated 2 part API key. It would then compile for whatever python version was on the actual system.

https://github.com/superm1/mythtv/commit/88acb0726c4c9b1e24c11d0ec8d3fce2eb8d8266

Change History (4)

comment:1 Changed 4 years ago by Jonatan Lindblad

Owner: set to Jonatan Lindblad
Status: newassigned

comment:2 Changed 4 years ago by Mario Limonciello <superm1@…>

Resolution: fixed
Status: assignedclosed

In 6fb78ae1c77c7ad29a68fcf5c27b771eb92f8739/mythtv:

Internet Content: Replace precompiled vimeo_data.pyc with the source vimeo_data.py.

vimeo_data.pyc was byte-compiled for python 2.6 and didn't work with any other
python versions.

vimeo_data.py holds the API key for connecting to vimeo. It it obfuscated,
however other projects do keep their key in the open.

discussion:
http://irc.mythtv.org/ircLog/channel/4/2013-10-08:21:50:00/2013-10-08:22:09:00

Fixes #11907

Signed-off-by: Jonatan Lindblad <jlindblad@…>

comment:3 Changed 4 years ago by Mario Limonciello <superm1@…>

In 9498257571e8158926b60a0eefc74568c4436823/mythtv:

Internet Content: Replace precompiled vimeo_data.pyc with the source vimeo_data.py.

vimeo_data.pyc was byte-compiled for python 2.6 and didn't work with any other
python versions.

vimeo_data.py holds the API key for connecting to vimeo. It it obfuscated,
however other projects do keep their key in the open.

discussion:
http://irc.mythtv.org/ircLog/channel/4/2013-10-08:21:50:00/2013-10-08:22:09:00

Fixes #11907

Signed-off-by: Jonatan Lindblad <jlindblad@…>
(cherry picked from commit 6fb78ae1c77c7ad29a68fcf5c27b771eb92f8739)

comment:4 Changed 4 years ago by Jonatan Lindblad

Milestone: unknown0.27.6
Note: See TracTickets for help on using tickets.