Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11939 closed Bug Report - General (Fixed)

mythtranscode honorcutlist doesn't honor commandline cutlist

Reported by: finlay@… Owned by: Jim Stichnoth
Priority: minor Milestone: 0.27.1
Component: MythTV - Mythtranscode Version: Unspecified
Severity: low Keywords:
Cc: Ticket locked: no

Description

When trying to specify a cutlist on the mythtranscode commandline using --honorcutlist it appears that the commandline cutlist is processed but during transcoding it is ignored and the internal db cutlist is used instead.

An example output illustrating the problem is:

finlay@curly:~/Videos$ mythtranscode -i /mythtv/sda/recordings/1093_20131003203000.mpg --honorcutlist '0-3000 20000-999999' --mpeg2 -o tst1.mpg --loglevel debug 2013-11-07 14:42:51.432004 C mythtranscode version: fixes/0.27 [v0.27-73-g0a5c67e] www.mythtv.org 2013-11-07 14:42:51.432024 C Qt version: compile: 4.8.1, runtime: 4.8.1 2013-11-07 14:42:51.432033 N Enabled verbose msgs: general 2013-11-07 14:42:51.432044 N Setting Log Level to LOG_DEBUG 2013-11-07 14:42:51.442696 D Cutting section 0-3000. 2013-11-07 14:42:51.442721 I Added logging to the console 2013-11-07 14:42:51.442725 D Cutting section 20000-999999. 2013-11-07 14:42:51.443406 I Setup Interrupt handler 2013-11-07 14:42:51.443415 I Setup Terminated handler 2013-11-07 14:42:51.443423 I Setup Segmentation fault handler 2013-11-07 14:42:51.443431 I Setup Aborted handler 2013-11-07 14:42:51.443439 I Setup Bus error handler 2013-11-07 14:42:51.443446 I Setup Floating point exception handler 2013-11-07 14:42:51.443454 I Setup Illegal instruction handler 2013-11-07 14:42:51.443465 I Setup Real-time signal 0 handler 2013-11-07 14:42:51.443501 N Using runtime prefix = /usr 2013-11-07 14:42:51.443512 N Using configuration directory = /home/finlay/.mythtv 2013-11-07 14:42:51.443579 I Assumed character encoding: en_US.UTF-8 2013-11-07 14:42:51.454997 N Empty LocalHostName?. 2013-11-07 14:42:51.455005 I Using localhost value of curly 2013-11-07 14:42:51.455039 I Testing network connectivity to '172.20.2.3' 2013-11-07 14:42:51.455284 I Starting process manager 2013-11-07 14:42:51.455362 I Starting process signal handler 2013-11-07 14:42:51.455452 I Starting IO manager (read) 2013-11-07 14:42:51.457090 I Starting IO manager (write) 2013-11-07 14:42:51.545729 I New Client: (#1) 2013-11-07 14:42:51.637123 D FindDatabase?() - Success! 2013-11-07 14:42:51.640581 N Setting QT default locale to EN_US 2013-11-07 14:42:51.640760 I Current locale EN_US 2013-11-07 14:42:51.640871 N Reading locale defaults from /usr/share/mythtvlocales/en_us.xml 2013-11-07 14:42:51.652917 I Loading en_us translation for module mythfrontend 2013-11-07 14:42:51.656455 N Transcoding from /mythtv/sda/recordings/1093_20131003203000.mpg to tst1.mpg 2013-11-07 14:42:51.656491 I Honoring the cutlist while transcoding 2013-11-07 14:42:51.904123 I Opening /mythtv/sda/recordings/1093_20131003203000.mpg 2013-11-07 14:42:51.934509 I PES packet size mismatch 2013-11-07 14:42:51.934546 I Input #0, mpegts, from '/mythtv/sda/recordings/1093_20131003203000.mpg': 2013-11-07 14:42:51.934559 I Duration: 00:29:58.14, start: 30548.941156, bitrate: 2798 kb/s 2013-11-07 14:42:51.934615 I Stream #0:0[0x51]: Video: mpeg2video (Main), yuv420p, 704x480 [SAR 10:11 DAR 4:3], 29.97 fps, 29.97 tbr, 90k tbn, 59.94 tbc 2013-11-07 14:42:51.934640 I Stream #0:1[0x54](eng): Audio: ac3, 48000 Hz, stereo, fltp, 192 kb/s 2013-11-07 14:42:51.936555 I #0 PTS:08:29:09.689 Delta: 0.0ms queue: 23 2013-11-07 14:42:51.936596 I #1 PTS:08:29:09.677 Delta: 12.0333ms queue: 2 2013-11-07 14:42:52.547322 I Del map found 0 at 3221 (3221) 2013-11-07 14:42:52.587509 I Mux rate: 15.44 Mbit/s 2013-11-07 14:43:07.019392 I Del map found 1 at 45674 (45674) 2013-11-07 14:43:07.391393 I Del map found 0 at 48280 (48280) 2013-11-07 14:43:07.489715 I Converting frame #3 from P to I 2013-11-07 14:43:08.034870 I Del map found 1 at 50181 (50181) 2013-11-07 14:43:08.559372 I PES packet size mismatch 2013-11-07 14:43:08.614454 I Generating Keyframe Index 2013-11-07 14:43:08.614475 I Opening tst1.mpg 2013-11-07 14:43:08.733756 I Input #0, mpeg, from 'tst1.mpg': 2013-11-07 14:43:08.733804 I Duration: 00:24:39.98, start: 0.305300, bitrate: 2703 kb/s 2013-11-07 14:43:08.733898 I Stream #0:0[0x1e0]: Video: mpeg2video (Main), yuv420p, 704x480 [SAR 10:11 DAR 4:3], 29.97 fps, 29.97 tbr, 90k tbn, 59.94 tbc 2013-11-07 14:43:08.733938 I Stream #0:1[0x80]: Audio: ac3, 48000 Hz, stereo, fltp, 192 kb/s 2013-11-07 14:43:14.655727 N Transcode Completed 2013-11-07 14:43:14.659086 N Transcoding /mythtv/sda/recordings/1093_20131003203000.mpg done

Attachments (1)

main.cpp.patch20131107 (424 bytes) - added by finlay@… 6 years ago.
patch to only use DB cutlist if deleteMap is empty

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Jim Stichnoth

It looks like main.cpp:637 overwrites deleteMap from the DB without checking whether it was supplied on the command line.

        if (useCutlist)
        {
            LOG(VB_GENERAL, LOG_INFO, "Honoring the cutlist while transcoding");
            pginfo->QueryCutList(deleteMap);
        }

Changed 6 years ago by finlay@…

Attachment: main.cpp.patch20131107 added

patch to only use DB cutlist if deleteMap is empty

comment:2 Changed 6 years ago by Jim Stichnoth

Milestone: unknown0.27.1
Owner: set to Jim Stichnoth
Status: newaccepted

comment:3 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

In 22409776f5d737dbf8a9b3d31d41498b20a59774/mythtv:

Mythtranscode: Don't overwrite cutlist from the command line.

Adapted from a patch by John Finlay. Refs #11939.

comment:4 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

In dfe53966fb66b9d846a4c2832a97e725bd082543/mythtv:

Mythtranscode: Don't overwrite cutlist from the command line.

Adapted from a patch by John Finlay. Refs #11939.
(cherry picked from commit 22409776f5d737dbf8a9b3d31d41498b20a59774)

comment:5 Changed 6 years ago by Jim Stichnoth

Resolution: Fixed
Status: acceptedclosed

comment:6 Changed 6 years ago by finlay@…

Unfortunately the patch that was put in reversed the logic of my patch so that a db cutlist will never be used unless a cutlist is passed on the command line.

if (!deleteMap.isEmpty())

should be:

if (deleteMap.isEmpty())

comment:7 Changed 6 years ago by Jim Stichnoth

D'oh! Sorry about that, and thanks for catching it.

comment:8 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

In a3033207fb2d7d7e75ff4167fe7813eee0e37710/mythtv:

Fix reversed logic in 2240977. Refs #11939.

comment:9 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

In 4e1342491d65d1d2b11e1e0f60bb48da1be7740b/mythtv:

Fix reversed logic in dfe5396. Refs #11939.

Note: See TracTickets for help on using tickets.