Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11942 closed Patch - Bug Fix (fixed)

Patch: Mythburn doesn't handle themes with no intro properly

Reported by: faginbagin <mythtv@…> Owned by: faginbagin <mythtv@…>
Priority: minor Milestone: 0.27.1
Component: Plugin - MythArchive Version: 0.27-fixes
Severity: medium Keywords: mythburn
Cc: Ticket locked: no

Description

If you try to create a DVD using a theme with no intro, mythburn creates a DVD that does nothing in many DVD players. Depending on the player, you may not be able to get to a menu or a title. The problem is the first <pgc> element, which looks like this:

<pgc entry="title">

</pgc>

Attached is a patch that adds a <post> element to this <pgc> when the theme doesn't have an intro. With the patch, the element looks like:

<pgc entry="title">

<post>{g3=1;g2=1;jump menu 2;}</post>

</pgc>

To verify the bug and the patch, take any theme with an intro, copy it to a new directory and remove or comment out the <intro> element. For example:

cd /usr/share/mythtv/mytharchive/themes/Black cp -a . ../Black-no-intro cd ../Black-no-intro Use your favorite editor to delete the intro element (should be line 13) from theme.xml

Then create a dvd using the theme Black-no-intro and try it in a DVD player. Without the attached patch, you probably won't be able to get to the menu or to play any titles using normal navigation with arrows and OK button.

Now apply the attached patch, create the DVD using the same theme and try it in the same DVD player. You should now see the menu as soon as the DVD is loaded and read by the player and be able to play titles listed in the menu using the OK and arrow buttons.

I have verified the problem and the patch using both VLC and a Panasonic DVD player.

Note: my version of mythburn.py has also been patched as described here: http://code.mythtv.org/trac/ticket/11758#comment:5 Without it, mythtranscode will fail. The attached patch does not include that fix.

Attachments (1)

mythburn-nointro.patch (796 bytes) - added by faginbagin <mythtv@…> 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by faginbagin <mythtv@…>

Attachment: mythburn-nointro.patch added

comment:1 Changed 6 years ago by John Pilkington <J.Pilk@…>

This looks as if it solves a problem I never knew I had. I perhaps worked around it by using whiteintro instead of the agressive mythtv_intro. I now have MythCenter_-_Animated-Nointro defined and going straight to the title menu. Thanks, Helen.

As a side effect it removes the visible MythTV branding.

comment:2 Changed 6 years ago by John Pilkington <J.Pilk@…>

One difference, which I haven't yet investigated. With this patch, and a multi-page title menu, selecting it returns to the first, not the current, page. MythTV-0.27-fixes, vlc 2.0.9

comment:3 Changed 6 years ago by faginbagin <mythtv@…>

Owner: set to faginbagin <mythtv@…>
Resolution: fixed
Status: newclosed

In 0a715bf3da19a0ac5e42b3f8ed6133ef71c163fc/mythtv:

MythArchive?: Fix problem playing created DVD's with no intro

This allows a DVD theme to be created that doesn't have an intro. All of the
default themes have a intro except the auto play theme which doesn't have this
problem so I haven't tested this at all. Fixes #11942.

Signed-off-by: Paul Harrison <pharrison@…>

comment:4 Changed 6 years ago by faginbagin <mythtv@…>

In 1faae446f62e977a29605a0c9952ae89cc789ae5/mythtv:

MythArchive?: Fix problem playing created DVD's with no intro

This allows a DVD theme to be created that doesn't have an intro. All of the
default themes have a intro except the auto play theme which doesn't have this
problem so I haven't tested this at all. Fixes #11942.

Signed-off-by: Paul Harrison <pharrison@…>
(cherry picked from commit 0a715bf3da19a0ac5e42b3f8ed6133ef71c163fc)

comment:5 Changed 6 years ago by paulh

Milestone: unknown0.27.1
Note: See TracTickets for help on using tickets.