Modify

Opened 4 years ago

Last modified 3 years ago

#12011 accepted Patch - Bug Fix

upnp NOTIFY messages are not sent

Reported by: steve_g@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: MythTV - UPnP Version: Master Head
Severity: medium Keywords: soap upnp
Cc: Ticket locked: no

Description

Myth is only visible to clients who actively request are you there.

libs/libmythupnp/mmulticastsocketdevice.h does not initialize m_local_addresses during instantiation and is never set anywhere else.

The result is that no interfaces are found and no messages sent. This behavior can be seen with any client that does not actively request (PS2's, Samsungs, some LG's). This fix puts the initialize in the header QList<QHostAddress> m_local_addresses = QNetworkInterface::allAddresses(); It could be put in the routines that use it with a "m_local_addresses = QNetworkInterface::allAddresses();" What I havent checked yet is that this message is redone periodical in case of router failure or the max-age expiring in the router.

build is v0.28-pre-678-g6530ac6-dirty

Attachments (1)

multicast.patch (615 bytes) - added by steve_g@… 4 years ago.
Patch for fixing upnp notify messages

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by steve_g@…

Patch for fixing upnp notify messages

comment:1 Changed 3 years ago by dekarl

  • Type changed from Bug Report - General to Patch - Bug Fix

comment:2 Changed 3 years ago by stuartm

  • Owner changed from dblain to stuartm
  • Status changed from new to accepted
  • Version changed from Unspecified to Master Head

Add Comment

Modify Ticket

Action
as accepted The owner will remain stuartm.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.