Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#12023 closed Patch - Bug Fix (fixed)

"Early start" setting is ignored if the DVB-Card is busy recording on the same multiplex

Reported by: lomion@… Owned by: stuartm
Priority: minor Milestone: 0.27.1
Component: MythTV - Scheduling Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If the DVB card is idle the recordings correctly start early according to the settings.

If the DVB card is already recording and has (correctly) scheduled another recording on the same multiplex then the recording starts with the original start time (ignoring the "start early" setting).

The attached patch fixes the problem. Check for side effects please!

Attachments (1)

IsBusyRecording.patch (1.0 KB) - added by lomion@… 6 years ago.

Download all attachments as: .zip

Change History (11)

Changed 6 years ago by lomion@…

Attachment: IsBusyRecording.patch added

comment:1 Changed 6 years ago by Raymond Wagner

Milestone: 0.27.1unknown
Resolution: Won't Fix
Status: newclosed

The setting you speak of is for hardware that needs extra time to "warm up" prior to use, such as an STB that goes into standby. If the hardware is already in use, then there's no need for the extra time defined there. If you are looking to add padding to the beginning or end of your recordings, those settings are made in the recording rules themselves.

comment:2 Changed 6 years ago by lomion@…

That's exactly what I meant (I'm using the english GUI so I don't know the correct terms).

If you look at scheduler.cpp line 2495 (fixes/0.27) there is a check if prerollseconds > 0 followed by the IsBusyRecording? check. Since IsBusyRecording? returns true even if the second tuner is recording on the same multiplex the start of the recording is delayed until the original air date.

If you won't fix it at least the patch is here for those having the same problem

comment:3 Changed 6 years ago by Raymond Wagner

If it's a value defined in seconds, then it's the soft padding to allow for startup time for recording devices. If the recording device is already active, then there is no need for startup, and thus no need to worry about the startup time. The padding for recordings is measured in minutes, not seconds. If you are using the soft padding to extend your recordings, you are using it improperly.

comment:4 Changed 6 years ago by stuartm

Resolution: Won't Fix
Status: closednew

comment:5 Changed 6 years ago by stuartm

Owner: changed from gigem to stuartm
Status: newaccepted

comment:6 Changed 6 years ago by lomion@…

Okay, in that case I am using the soft padding feature improperly but it used to work for me. I used the padding at the beginning to work around the fact that the EIT-start times never match exactly the real air times of the showings. So this way my recordings start a few seconds earlier, I can be sure to start recording right before the show begins and I don't have to manually add a padding for every recording rule. Although I do this by using recording rule templates in 0.27.

comment:7 Changed 6 years ago by David Engel <dengel@…>

Resolution: fixed
Status: acceptedclosed

In 11e65dfd38ca419b2157f0dbaa19f965647f648c/mythtv:

Apply preroll on virtual tuners when the same multiplex is in use.

Previously, if any tuner in the same input group was already busy,
preroll would not be applied. Now, if the recording on the other
input is on the same multiplex as the new recording, preroll will be
applied.

Fixes #12023

comment:8 Changed 6 years ago by gigem

Version: 0.27-fixesMaster Head

comment:9 Changed 6 years ago by David Engel <dengel@…>

In 6b14852a6a3750e1d5c1bf7d461a5338ef535cbb/mythtv:

Apply preroll on virtual tuners when the same multiplex is in use.

Previously, if any tuner in the same input group was already busy,
preroll would not be applied. Now, if the recording on the other
input is on the same multiplex as the new recording, preroll will be
applied.

Refs #12023

(cherry picked from commit 11e65dfd38ca419b2157f0dbaa19f965647f648c)

comment:10 Changed 5 years ago by paulh

Milestone: unknown0.27.1
Note: See TracTickets for help on using tickets.