mythwelcome removes startup block on shutdown

[timothymee@…]

In 0.26, I booted my PC to mythwelcome and it would stay there until I clicked on the Start Frontend button. In 0.27, I boot to mythwelcome and it automatically shuts down without clicking the Start Frontend button.

Mythbackend has setting "block before client connected" enabled. As part of startup programs, mythfrontend --service is executed. /etc/mythtv/session-settings has MYTHWELCOME=true set. Booting the PC causes mythwelcome screen to display. /var/log/mythbackend logs "Scheduler: Seem to be woken up by USER" and "Client is connected, removing startup block on shutdown". Mythwelcome connections should NOT cause the startup block to be removed. Since mythwelcome does not count as a client connection for shutdown purposes, mythbackend shuts down the system. The PC should not shutdown until I start the frontend. If I start the frontend and leave it running, the PC does not shutdown (as it should).

[sp4@…]

This was bothering me too. patch:

diff --git a/mythtv/programs/mythbackend/scheduler.cpp b/mythtv/programs/mythbackend/scheduler.cpp
index a5eb1a1..c5d7a6e 100644
--- a/mythtv/programs/mythbackend/scheduler.cpp
+++ b/mythtv/programs/mythbackend/scheduler.cpp
@@ -2841,7 +2841,7 @@
     // the frontend may have connected then gone idle between scheduler runs
     if (blockShutdown)
     {
-        if (m_mainServer->isClientConnected())
+        if (m_mainServer->isClientConnected(true))
         {
             LOG(VB_GENERAL, LOG_NOTICE, "Client is connected, removing startup block on shutdown");
             blockShutdown = false;

Should I make a gihub pull request?

[sp4@…]

​https://github.com/MythTV/mythtv/pull/130

[Stuart Auchterlonie]

Closing any remaining tickets for 0.28, if the issue persists, feel free to reopen and align to v29 or master