Metadata lookup broken by recent changes

[Frank Phillips <fphillips81@…>]

In fixes/0.27, between [6435215] and [f6b2f74] the lookup fails to run. Information Center says error 140. See attached.

[JYA]

Where are you trying to grab data?

In the recordings screen and on a recording.

In the videos group, pressing Info -> Details -> Retrieve all details?

thanks

[Frank Phillips <fphillips81@…>]

The logs were from manual mythmetadatalookup runs, but I first saw that the automatic runs for recordings were failing.

[JYA]

Please provide the command line that you ran...

[Frank Phillips <fphillips81@…>]

mythmetadatalookup --chanid 1421 --starttime 201407110200 -v all,norefcount --loglevel debug

The auto runs ended the same way in their logs, even after requeuing: 2014-07-11 01:31:53.819718 I [20889/20889] CoreContext? main.cpp:128 (main) - Testing grabbers and metadata sites for functionality...

It aborts before printing: 2014-07-11 02:09:04.864960 D Launching: /usr/share/mythtv/metadata/Television/ttvdb.py -t

The script itself works: [mythtv@central ~]$ /usr/share/mythtv/metadata/Television/ttvdb.py -t Everything appears to be in order [mythtv@central ~]$ /usr/share/mythtv/metadata/Television/ttvdb.py -D 266189 1 1 <?xml version='1.0' encoding='UTF-8'?> <metadata>

<item>

<title>The Blacklist</title> <subtitle>Pilot</subtitle> <language>en</language> <description>A criminal mastermind surrenders to the FBI with a stunning offer - but he'll only talk to a rookie profiler.</description> <season>1</season> <episode>1</episode> <certifications>

<certification locale="us" name="TV-14"/>

<...>

[Frank Phillips <fphillips81@…>]

It receives a SIGABRT, so I guess some memory misallocation, double free, etc. When I go back to the earlier version, it runs fine. The issue isn't that there are no results returned, its that the process isn't launching successfully.

[Raymond Wagner]

It appears things were already broken in [6435215].

167	2014-07-11 02:09:05.084494 I  Running Grabber: /usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M
168	2014-07-11 02:09:05.084512 D  Launching: /usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M
169	2014-07-11 02:09:05.089633 I  Managed child (PID: 22902) has started!  command=/usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M, timeout=0
170	2014-07-11 02:09:05.460657 I  Managed child (PID: 22902) has exited! command=/usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M, status=256, result=1
171	2014-07-11 02:09:05.465004 I  Running Grabber: /usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M
172	2014-07-11 02:09:05.465026 D  Launching: /usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M
173	2014-07-11 02:09:05.470086 I  Managed child (PID: 22905) has started!  command=/usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M, timeout=0
174	2014-07-11 02:09:05.760979 I  Managed child (PID: 22905) has exited! command=/usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M, status=0, result=0
175	2014-07-11 02:09:05.765231 I  Metadata Lookup Failed: No Results  0 0

You're trying to perform a metadata search with an empty title.

As for the new version, the "Handling Aborted" error is not one of ours. Is mythmetadatalookup crashing?

[JYA]

it's a bad handling on the string, that fix is easy

[Jean-Yves Avenard <jyavenard@…>]

In 419e06b45068a088dc28caf7c9e6999ee3c93231/mythtv:

metadata: fix crash should grabber not be defined

Fixes #12206

[Frank Phillips <fphillips81@…>]

Replying to wagnerrp:

It appears things were already broken in [6435215].

167	2014-07-11 02:09:05.084494 I  Running Grabber: /usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M
168	2014-07-11 02:09:05.084512 D  Launching: /usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M
169	2014-07-11 02:09:05.089633 I  Managed child (PID: 22902) has started!  command=/usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M, timeout=0
170	2014-07-11 02:09:05.460657 I  Managed child (PID: 22902) has exited! command=/usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a US -M, status=256, result=1
171	2014-07-11 02:09:05.465004 I  Running Grabber: /usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M
172	2014-07-11 02:09:05.465026 D  Launching: /usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M
173	2014-07-11 02:09:05.470086 I  Managed child (PID: 22905) has started!  command=/usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M, timeout=0
174	2014-07-11 02:09:05.760979 I  Managed child (PID: 22905) has exited! command=/usr/share/mythtv/metadata/Television/ttvdb.py -l en -a US -M, status=0, result=0
175	2014-07-11 02:09:05.765231 I  Metadata Lookup Failed: No Results  0 0

You're trying to perform a metadata search with an empty title.

As for the new version, the "Handling Aborted" error is not one of ours. Is mythmetadatalookup crashing?

No, sorry, I was missing a coule of zeroes on the end of the starttime in the command I ran, so it wasn't finding anything in the database. Please ignore.

Yes, MML was getting SIGABRT.

Jean-Yves, here are my settings FYI:

+--------------------------+---------------------------------------------------------+----------+
| value                    | data                                                    | hostname |
+--------------------------+---------------------------------------------------------+----------+
| MythMovies.Grabber       | /usr/bin/ignyte --zip %z --radius %r                    | central  |
| mythvideo.TVGrabber      | /usr/share/mythtv/mythvideo/scripts/Television/ttvdb.py | viron    |
| mythvideo.MovieGrabber   | /usr/share/mythtv/mythvideo/scripts/Movie/tmdb.py       | viron    |
| TelevisionGrabber        | metadata/Television/ttvdb.py                            | NULL     |
| MovieGrabber             | metadata/Movie/tmdb3.py                                 | NULL     |
| mythgame.MetadataGrabber |                                                         | ion      |
| mythgame.MetadataGrabber |                                                         | central  |
| mythgame.MetadataGrabber |                                                         | viron    |
+--------------------------+---------------------------------------------------------+----------+

Is it the empty hostname that caused the problem?

[Jean-Yves Avenard <jyavenard@…>]

In 9ddb3d438d6471bbcf4b9d9b8fcd9e745c905f25/mythtv:

metadata: fix crash should grabber not be defined

Fixes #12206

(cherry picked from commit 419e06b45068a088dc28caf7c9e6999ee3c93231)

[Frank Phillips <fphillips81@…>]

With [9ddb3d4]: mythmetadatalookup --chanid 1241 --starttime 20140711010000 -v all,norefcount --loglevel debug

2014-07-11 13:06:30.617723 I  Testing grabbers and metadata sites for functionality...
2014-07-11 13:06:30.618191 D  MSqlQuery::exec(DBManager1) SELECT data FROM settings WHERE value = 'moviegrabber' AND hostname = 'central' <<<< Returns 0 row(s)
2014-07-11 13:06:30.618555 D  MSqlQuery::exec(DBManager1) SELECT data FROM settings WHERE value = 'moviegrabber' AND hostname IS NULL <<<< Returns 1 row(s)
2014-07-11 13:06:30.618575 D  MSqlQuery::next(DBManager1) Result: "data = metadata/Movie/tmdb3.py"
2014-07-11 13:06:30.618646 I  Movie grabber not functional.  Aborting this run.

[Jean-Yves Avenard <jyavenard@…>]

In 44775b1785110949ef5970cffb9acdb32fc72c92/mythtv:

metadata: do not use grabber cache if not initialised

There’s no guarantee that a non-static member will be initialised.
Make all global variable static, there is no reason to export them

Fix #12206 part 2

[Frank Phillips <fphillips81@…>]

Ok, cherry picked [44775b1] works now, thanks.

[Jean-Yves Avenard <jyavenard@…>]

In 7e8ca1c3e74af4202cda42be4dd2cdf505df9d8f/mythtv:

metadata: do not use grabber cache if not initialised

There’s no guarantee that a non-static member will be initialised.
Make all global variable static, there is no reason to export them

Fix #12206 part 2

(cherry picked from commit 44775b1785110949ef5970cffb9acdb32fc72c92)