Opened 11 years ago

Closed 11 years ago

#12235 closed Patch - Bug Fix (fixed)

Patch to protect against null pointer deref in langsettings.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (scan-build) detected a potential NULL pointer de-ref (use after checking for NULL) in langsettings.cpp. In the case of NULL, return, with logging. In addition, do the same later in the code, since GetItemCurrent? can return NULL. Segmentation faults are rarely a good way to exit a program.

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/af3ed4cea7bb09747a5e7d1cedad64b4eb66dec3 github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/af3ed4cea7bb09747a5e7d1cedad64b4eb66dec3.patch

Change History (4)

comment:1 Changed 11 years ago by Gary Buhrmaster <gary.buhrmaster@…>

'Create ticket' got away from me before I finished the title. Please consider changing the title to something like "Patch to protected against null pointer deref in langsettings.cpp".

comment:2 Changed 11 years ago by Raymond Wagner

Summary: Patch to → Patch to protect against null pointer deref in langsettings.cpp

comment:3 Changed 11 years ago by stuartm

Milestone: unknown → 0.28
Owner: set to stuartm
Status: new → accepted

comment:4 Changed 11 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: → fixed
Status: accepted → closed

In a5f69cdba52e2fe6b007d769c2196bf6e0db91c3/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available
Note: See TracTickets for help on using tickets.