Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12237 closed Patch - Bug Fix (fixed)

Patch to correct allocator sizeof operand mismatch

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: trivial Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Static analysis (scan-build) reports that the allocator sizeof operand is mismatched from the usage. While for all common architectures, the size of a signed and unsigned char/int is the same, that is not assured for all platforms. Patch is to use a consistent sizeof operand. This patch is split into two parts, since it impacts two different files.

Patch 1 - github ref: https://github.com/garybuhrmaster/mythtv/commit/2c75c0cf4dde57f2f2c0857a0f807ef5289bf0ac github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/2c75c0cf4dde57f2f2c0857a0f807ef5289bf0ac.patch

Patch 2 - github ref: https://github.com/garybuhrmaster/mythtv/commit/6d88020537a73c59bc350efe10ccde77817e783b github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/6d88020537a73c59bc350efe10ccde77817e783b.patch

Change History (3)

comment:1 Changed 5 years ago by stuartm

Milestone: unknown0.28
Owner: set to stuartm
Status: newaccepted

comment:2 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: acceptedclosed

In 9e27d8ff5c6655b5027f154a694623f42e4a23d0/mythtv:

Patch to use consistent cast and sizeof operands

Fixes #12237

Signed-off-by: Stuart Morgan <smorgan@…>

comment:3 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

In cde473cef3bd38a47ae38eab83b8376567c3af20/mythtv:

Patch to use consistent cast and sizeof operands in allocator

Fixes #12237

Signed-off-by: Stuart Morgan <smorgan@…>

Note: See TracTickets for help on using tickets.