Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12251 closed Patch - Bug Fix (fixed)

Patch - Add logging when file opens fail in datadirect.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.28
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Discussion on mythtv-users pointed out that there are some code paths that can result in unreported errors when downloading data from Schedules Direct, often due to permission errors when people incorrectly use mixed usernames between mythtv-setup, mythbackend, and mythfilldatabase.

This patch does not address the core issue (re-use of a fixed file name), but provides error reporting so that the logs will identify the error(s) if a file open fails. At least the errors will be now be reported (rather than invisible). Better living through logging.

A later patch (when more fully tested) will use randomized temporary file names where possible, mitigating the most common issues. But I have not yet completed my testing, and better logging is appropriate in any case (and the later patch will likely require an ABI bump, so should be separate anyway).

github ref: https://github.com/garybuhrmaster/mythtv/commit/b6f41381a9a7017fda4ec7b66cbe006bc282879d github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/b6f41381a9a7017fda4ec7b66cbe006bc282879d.patch

Change History (3)

comment:1 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: newclosed

In f4634d2ea524baf2e7c2d99995b7b565e635cd07/mythtv:

DataDirectProcessor?: Add logging when file opens fail

Fixes #12251.

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 5 years ago by paulh

Milestone: unknown0.28

comment:3 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

In aad702d8e0e1cd5d04241bedc5477380f06167f4/mythtv:

DataDirectProcessor?: Add logging when file opens fail

Fixes #12251.

Signed-off-by: Paul Harrison <pharrison@…>
(cherry picked from commit f4634d2ea524baf2e7c2d99995b7b565e635cd07)

Note: See TracTickets for help on using tickets.