Opened 7 years ago

Closed 11 months ago

#12254 closed Patch - Bug Fix (Unverified)

MythGame settings not initialized in the database

Reported by: jjiglesias@… Owned by:
Priority: minor Milestone: unknown
Component: Plugin - MythGame Version: 0.27.3
Severity: low Keywords:
Cc: Ticket locked: no


Certain MythGame? settings variables are not initialized in the database, so that they can't be used until the first modification of MythGame? settings is performed through its setting user interface. This causes, for example, that those games marked as favorite don't appear in the Favorites listing, at the Games UI. To list favorite games, an SQL query is created with the content of the GameFavTreeLeves? setting. If this setting doesn't exist in the database, the query created is wrong and fails. Aa a result, no favorite games apperar on screen. I've proposed a patch that initializes these variables.

Change History (6)

comment:1 Changed 7 years ago by jjiglesias@…

Proposed patch pull request:

comment:2 Changed 7 years ago by sphery

Plugin settings should not be initialized in MythTV (core) dbcheck. Rather it's up to the plugin to create necessary settings. This can be done either by calling a function in mythplugin_init() to check and pre-populate settings (so it is done when the frontend is started on a particular host) or by handling non-existent settings within the code that uses them (either by specifying default values in the GetSetting?() calls or by using a conditional to check values).

Furthermore, fixes should be made in MythGame? itself, not in a packaging script used only by debian-based system packagers.

comment:3 Changed 7 years ago by jjiglesias@…

I've just seen an example of mythplugin_init() in mythbrowser/main.cpp. Thank you.

comment:4 Changed 5 years ago by Karl Egly

Status: newinfoneeded_new

Hi Jose, are you updating the patch in the near future or should this tracking ticket of the discarded pull request be discarded, too? You can always reopen it or open a new ticket once the new patch is ready.

comment:5 Changed 17 months ago by paul-h

Status: infoneeded_newnew

No new patch supplied but this is a genuine bug and should be fixed eventually.

comment:6 Changed 11 months ago by Stuart Auchterlonie

Resolution: Unverified
Status: newclosed

Closing all old tickets in trac.

If your issue still persists, please open an issue in Github

and reference the existing trac ticket.

Note: See TracTickets for help on using tickets.