Implement newer media handling methods (udisks2, storaged)

[J.Pilk@…]

I'm running a new home-brew of master under SL7 (el7). On starting mythfrontend I get a bunch of

MMUnix:CheckMountable: DBus interface error: The name org.freedesktop.UDisks was not provided by any .service files.
My repos apparently provide only udisk2 and the config file,

/etc/dbus-1/system.d/org.freedesktop.UDisks2.conf

looks for <allow own="org.freedesktop.UDisks2"/>

The source file is mythtv/libs/libmyth/mediamonitor-unix.cpp

[Stuart Auchterlonie]

This needs to be fixed, as well as the 10 seconds it spends trying to connect with the service before it gives up.

udisks2 is now common, udisks1 is quite old

[Stuart Auchterlonie]

See also #12500, need to add support here for udisks2 dbus service

[Stuart Auchterlonie <stuarta@…>]

In 8f6b99e45f3de1a8278ede7b0d3644901a034f28/mythtv:

Refs #12307 Check if UDisks2 is in use.

First check for the original UDisks service,
if we fail to find it, check for UDisks2.

If we find UDisks2 service, then this system
has moved to UDisks2, rather than UDisks1.

For now log a message and give up. This will
reduce the frontend startup time by the 5 seconds
the loop takes to complete and fail.

TODO: Implement the same support via UDisks2 interface

[Stuart Auchterlonie <stuarta@…>]

In 71276fae30214310237b2dcffc1421379f148b5f/mythtv:

Refs #12307 Check if UDisks2 is in use.

First check for the original UDisks service,
if we fail to find it, check for UDisks2.

If we find UDisks2 service, then this system
has moved to UDisks2, rather than UDisks1.

For now log a message and give up. This will
reduce the frontend startup time by the 5 seconds
the loop takes to complete and fail.

TODO: Implement the same support via UDisks2 interface

[Stuart Auchterlonie]

Milestone renamed

[Stuart Auchterlonie]

Udisks2 has itself been replaced by storaged on newer Fedora releases.

​https://fedoraproject.org/wiki/Changes/Replace_UDisks2_by_Storaged

[angelaschmid]

I have media monitoring disabled (MonitorDrives?=0), but still these UDisk messages appear and starting MythTV takes 5 seconds longer.

MythTV starts MediaMonitor::GetMediaMonitor?() where the UDisk messages are generated and the delay happens.

In MediaMonitor::StartMonitoring?() the decision is made if the user has "MonitorDrives?" enabled and the monitoring thread is started.

The check for "MonitorDrives?" has to be made earlier.

programs/mythfrontend/main.cpp

    MediaMonitor *mon = MediaMonitor::GetMediaMonitor();
    if (mon)
    {
        mon->StartMonitoring();
        mainWindow->installEventFilter(mon);
    }

libs/libmyth/mythmediamonitor.cpp

void MediaMonitor::StartMonitoring(void)
{
    // Sanity check
    if (m_Active)
        return;
    if (!gCoreContext->GetNumSetting("MonitorDrives", 0)) {
        LOG(VB_MEDIA, LOG_NOTICE, "MediaMonitor diasabled by user setting.");
        return;
    }

    if (!m_Thread)
        m_Thread = new MonitorThread(this, m_MonitorPollingInterval);

    qRegisterMetaType<MythMediaStatus>("MythMediaStatus");

    LOG(VB_MEDIA, LOG_NOTICE, "Starting MediaMonitor");
    m_Active = true;
    m_Thread->start();
}

[Stuart Auchterlonie <stuarta@…>]

In d09f11da0/mythtv:

Refs #12307 - Respect the user setting to disable media monitor

Also fix a typo in the message stating it is disabled.

[Stuart Auchterlonie <stuarta@…>]

In d3088629de/mythtv:

Refs #12307 - Respect the user setting to disable media monitor

Also fix a typo in the message stating it is disabled.

(cherry picked from commit d09f11da0e946a099cfbe04f5b64c32eb3e7ee64)

[Stuart Auchterlonie]

We have moved all bug tracking to github [1]

If you continue to have this issue, please open a new issue at github, referencing this ticket.

[1] - ​https://github.com/MythTV/mythtv/issues