Opened 5 years ago

Closed 18 months ago

#12332 closed Bug Report - General (fixed)

MythTV turns visibility back on after channel update

Reported by: bib_aab@… Owned by: gigem
Priority: minor Milestone: 30.0
Component: MythTV - Channel Scanner Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

I have the visibility of certain channels turned off, mainly the porn & shopping channels.

However, when I do a channel update, the channels are all set to have their visibility turned back on.

MythTV should not be touching a existing channels visibility.

Attachments (3)

20181218_123332_visible.patch (1.3 KB) - added by Klaas de Waal 18 months ago.
git diff of channelutil.cpp
channelutil.cpp (79.1 KB) - added by Klaas de Waal 18 months ago.
Complete file, modified for not updating visible field.
20181220_12332_visible-persistent.patch (1.1 KB) - added by Klaas de Waal 18 months ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 5 years ago by bib_aab@…

Is this fixed yet?

comment:2 Changed 5 years ago by stuartm

This was fixed years ago, I'm not sure when it broke again, if it did.

You don't include version information.

comment:3 Changed 5 years ago by bib_aab@…

I've rechecked with the latest head, indeed, it's saying Master Head on the ticket.

Scan for channels, tell it to update automatically, and it turns visibility back on.

comment:4 Changed 5 years ago by bib_aab@…

Rechecked with todays head, and it is still happening.

comment:5 Changed 5 years ago by Stuart Auchterlonie

No work has been done in this area recently so it won't have been fixed

Regards Stuart

comment:6 Changed 18 months ago by Klaas de Waal

Checked today and the problem still exists.

Changed 18 months ago by Klaas de Waal

git diff of channelutil.cpp

Changed 18 months ago by Klaas de Waal

Attachment: channelutil.cpp added

Complete file, modified for not updating visible field.

comment:7 Changed 18 months ago by Klaas de Waal

Fixed this by not updating the visible field in file channelutil.cpp function ChannelUtil::UpdateChannel? in the master of yesterday (20181218).

Tested with DVB-C (Ziggo, The Netherlands) by doing a rescan of a single transport. The "visible" state entered by the user with mythtv-setup is now persistent across rescans. Deleting the channel and then adding it again with a rescan makes the channel visible again.

The "git diff" patch and the complete file channelutil.cpp have been attached.

comment:8 Changed 18 months ago by gigem

The proposed patch will break the services API and any other callers of ChannelUtil::UpdateChannel?() that do need to update channel.visible.

comment:9 Changed 18 months ago by Klaas de Waal

New fix to preserve the value of the visible field in the database with a rescan.
Implementation is in ChannelUtil::UpdateInsertInfoFromDB, called from ChannelImporter::UpdateChannels?.
The value of visible is retrieved from the database and used to update the channel information. This was already done for the fields xmltvid and useonairguide for which similar considerations (user defined values should not be changed by a rescan) hold. Patch will be attached.

Changed 18 months ago by Klaas de Waal

comment:10 Changed 18 months ago by gigem

Milestone: unknown30.0
Owner: set to gigem
Status: newassigned

comment:11 Changed 18 months ago by Klaas de Waal <klaas.de.waal@…>

Resolution: fixed
Status: assignedclosed

In 4d5607fbf8/mythtv:

Preserve channel.visible when updating a scanned channel.

Previously, channel.visible was always being reset to visible when a
channel was updated.

Fixes: #12332

Signed-off-by: David Engel <dengel@…>

Note: See TracTickets for help on using tickets.