Opened 9 years ago
Closed 5 years ago
#12332 closed Bug Report - General (fixed)
MythTV turns visibility back on after channel update
Reported by: | Owned by: | gigem | |
---|---|---|---|
Priority: | minor | Milestone: | 30.0 |
Component: | MythTV - Channel Scanner | Version: | Master Head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
I have the visibility of certain channels turned off, mainly the porn & shopping channels.
However, when I do a channel update, the channels are all set to have their visibility turned back on.
MythTV should not be touching a existing channels visibility.
Attachments (3)
Change History (14)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
This was fixed years ago, I'm not sure when it broke again, if it did.
You don't include version information.
comment:3 Changed 9 years ago by
I've rechecked with the latest head, indeed, it's saying Master Head on the ticket.
Scan for channels, tell it to update automatically, and it turns visibility back on.
comment:5 Changed 9 years ago by
No work has been done in this area recently so it won't have been fixed
Regards Stuart
Changed 5 years ago by
Attachment: | channelutil.cpp added |
---|
Complete file, modified for not updating visible field.
comment:7 Changed 5 years ago by
Fixed this by not updating the visible field in file channelutil.cpp function ChannelUtil::UpdateChannel? in the master of yesterday (20181218).
Tested with DVB-C (Ziggo, The Netherlands) by doing a rescan of a single transport. The "visible" state entered by the user with mythtv-setup is now persistent across rescans. Deleting the channel and then adding it again with a rescan makes the channel visible again.
The "git diff" patch and the complete file channelutil.cpp have been attached.
comment:8 Changed 5 years ago by
The proposed patch will break the services API and any other callers of ChannelUtil::UpdateChannel?() that do need to update channel.visible.
comment:9 Changed 5 years ago by
New fix to preserve the value of the visible field in the database with a rescan.
Implementation is in ChannelUtil::UpdateInsertInfoFromDB, called from ChannelImporter::UpdateChannels?.
The value of visible is retrieved from the database and used to update the channel information. This was already done for the fields xmltvid and useonairguide for which similar considerations (user defined values should not be changed by a rescan) hold.
Patch will be attached.
Changed 5 years ago by
Attachment: | 20181220_12332_visible-persistent.patch added |
---|
comment:10 Changed 5 years ago by
Milestone: | unknown → 30.0 |
---|---|
Owner: | set to gigem |
Status: | new → assigned |
comment:11 Changed 5 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Is this fixed yet?