Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12351 closed Bug Report - General (fixed)

Genre colors broken .0.27

Reported by: cato@… Owned by: Karl Egly
Priority: minor Milestone: 0.27.5
Component: Plugin - MythWeb Version: Unspecified
Severity: medium Keywords: genre colors
Cc: Ticket locked: no

Description

symptom: Skinned genre colors no longer working as expected in MythWeb's Program Listing. Specifically, movies are muddy brown - the color that signifies 'unknown'.

cause: The CSS class name has changed from eg 'cat_movie' to 'type_movie'

fix: The skins have

.cat_movie { background-color: #809090 !important; }
.cat_series { }
.cat_tvshow { }

in programming.css.

As the HTML code shows:

<td class="small type_movie cat_Unknown" colspan="17" style="width: 45%" valign="top"><a id = "program-10220-1421843700"

The skins need to be changed such that

.type_movie { background-color: #809090 !important; }
.type_series { }
.type_tvshow { }

in programming.css

There may be further CSS tweaks required - I just needed this one. :-)

Change History (8)

comment:1 Changed 5 years ago by Karl Egly

Owner: changed from Rob Smith to Karl Egly
Status: newaccepted

comment:2 Changed 5 years ago by Karl Dietz <dekarl@…>

Resolution: fixed
Status: acceptedclosed

In 1b86b5763e4c55bed4428bb227079a1ce0568e80/mythweb:

unbreak guide colors based on category_type

It appears as if changes around other areas of the guide code uncovered
this issue which has been around for a long time.

Fixes #12351

comment:3 Changed 5 years ago by Karl Dietz <dekarl@…>

In e0c2a3aea94bc96be5836472a1c53e62b5e43c93/mythweb:

unbreak guide colors based on category_type

It appears as if changes around other areas of the guide code uncovered
this issue which has been around for a long time.

Fixes #12351
(cherry picked from commit 1b86b5763e4c55bed4428bb227079a1ce0568e80)

comment:4 Changed 5 years ago by Karl Egly

Milestone: unknown0.27.5

comment:5 Changed 5 years ago by stuartm

Both cat_movie and type_movie classes need to exist, so the fix committed is incorrect. They represent two different things internally.

To fix, the cat_movie definition needs to be re-added alongside the type_movie definition.

comment:6 Changed 5 years ago by stuartm

OK, after further discussion with Jim about what he was seeing and what the expected behaviour was it seems that it's more a case of moving the type_ rules so that the cat_ rules take precedence. Jim will commit the change.

comment:7 Changed 5 years ago by Jim Stichnoth <jstichnoth@…>

In cb588d870f215a4e65854a4665cc01b95dc4547e/mythweb:

Move .type_* entries above .cat_* entries. Refs #12351

This makes categories take precedence over types when deciding on
colors, resulting in a more colorful (and easier to read) search
results page.

comment:8 Changed 5 years ago by Jim Stichnoth <jstichnoth@…>

In 799db438533acd7fed7b9137b63badb6f163b7da/mythweb:

Move .type_* entries above .cat_* entries. Refs #12351

This makes categories take precedence over types when deciding on
colors, resulting in a more colorful (and easier to read) search
results page.

(cherry picked from commit cb588d870f215a4e65854a4665cc01b95dc4547e)

Note: See TracTickets for help on using tickets.