Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#12359 closed Patch - Feature (fixed)

C++11 feature patch - external/libmythsoundtouch/cpu_detect_x86_gcc.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: JYA
Priority: trivial Milestone: 0.28
Component: MythTV - Audio Output Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The C++11 standard requires a space between literal and identifier in order to support user defined literal types via suffixes.

This patch provides the needed spaces around the use of the defines.

As C++11 is not currently required by MythTV, this should be considered a really low priority in the code cleanliness queue.

Note: A better fix would be to update to the latest soundtouch library, but that requires much more analysis and testing time to insure that the improvements to soundtouch in current versions (esp. multi-channel) are compatible with the existing MythTV patches for multi-channel. This is a minimal update for C++11 compliance.

github ref: https://github.com/garybuhrmaster/mythtv/commit/8c92ae1ba905696f4ab4bf82296e8969fbcd0756
github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/8c92ae1ba905696f4ab4bf82296e8969fbcd0756.patch

Change History (2)

comment:1 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: newclosed

In eb2f96e9d5e8a9707476809346f3312348645d19/mythtv:

C++11 literal string suffix compliance

Signed-off-by: Stuart Morgan <smorgan@…>

Fixes #12359

comment:2 Changed 4 years ago by Karl Egly

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.