Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12381 closed Patch - Bug Fix (fixed)

Patch for mythdownloadmanager for improved POST redirect compatibility

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Patch for mythdownloadmanager for improved POST redirect compatibility

Per the specs, and de-facto implementations, redirects for POSTs are (for status codes 301, 302, and 303) turned into GETs (302 was ambiguous in the original spec, and all (well, almost all) browsers turned a 302 into a GET, so later an explicit 303 was defined that defined that redirected POSTs should be implemented as GETs, but the 302 behavior was codified). A 307 says to rePOST, but it also requires asking the submitter to re-verify, so the code will not (automatically) redirect.

Note that the existing code which attempted to redirect a POST to a POST was somewhat flawed (not only by spec), but because the post data was no longer available to rePOST with.

github ref: https://github.com/garybuhrmaster/mythtv/commit/9cb68f24aed3d7c67b68672912d55c7f03af6391
github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/9cb68f24aed3d7c67b68672912d55c7f03af6391.patch

Change History (2)

comment:1 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: fixed
Status: newclosed

In e48dc36c3a7cca37c46baaa9e0ccc506ae7352b5/mythtv:

Enhance mythdownloadmanager POST redirect compatibility

Fixes #12381

Signed-off-by: David Engel <dengel@…>

comment:2 Changed 4 years ago by gigem

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.