Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#12436 closed Patch - Feature (fixed)

Patch for fixup for Greek DVB EIT

Reported by: Yianni Vidalis <yiannividalis@…> Owned by: Karl Egly
Priority: minor Milestone: 0.28
Component: MythTV - EIT Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi,

I've added fixing for the EIT data of the Greek DVB providers. It covers the transmitter of Pelion, which I receive. I've made the corrections only on the transport ids and not the netword ids, trying to keep the scope as precise as possible.

National TV must be ok for the whole country, but other region's channels will not be affected.

The fixes consist of:

  • Correction of codepage for Nat. TV.
  • Moving the event's subtitle to the description, as it was misusing the subtitle field (actors, category, etc unnecessary info).
  • Reading category data from EIT where available
  • Using regexp to extract actors, directors, season and episode, and category data from the description field.
  • Updating the categories.xml file of the standard theme with the Greek translations.

I'm planning to extend the patch to include parental data extracted either from EIT or from the description, but I'm submitting what I have so far for review.

Comments, suggestions are welcome.

Thanks again for this great program.

Attachments (4)

eitfixup-greek.diff (33.2 KB) - added by Yianni Vidalis <yiannividalis@…> 5 years ago.
eitfixup-greek-2015-04-25.diff (35.3 KB) - added by Yianni Vidalis <yiannividalis@…> 5 years ago.
v2
eitfixup-greek-diff-as-sent-to-04-25.diff (8.3 KB) - added by Yianni Vidalis <yiannividalis@…> 5 years ago.
diff between v1 and v2
eitfixup-greek.2.diff (34.2 KB) - added by yiannividalis@… 4 years ago.
update after e7a20aa

Download all attachments as: .zip

Change History (14)

Changed 5 years ago by Yianni Vidalis <yiannividalis@…>

Attachment: eitfixup-greek.diff added

comment:1 Changed 5 years ago by Yianni Vidalis <yiannividalis@…>

Well, I'm adding v2, which has corrections based on new eit data, and new field additions. I'm attaching a drop-in replacement (eitfixup-greek-2015-04-25.diff) and the diff between the two versions (eitfixup-greek-diff-as-sent-to-04-25.diff).

Changed 5 years ago by Yianni Vidalis <yiannividalis@…>

v2

Changed 5 years ago by Yianni Vidalis <yiannividalis@…>

diff between v1 and v2

comment:2 Changed 5 years ago by Yianni Vidalis <yiannividalis@…>

I was hoping to add support for parental levels by using eit info, but I've seen that the class ParentalRatingDescriptor? : public MPEGDescriptor in dvbdescriptors.h file is commented out since its addition in 2005: https://github.com/MythTV/mythtv/commit/858e8fd7f6ba5b820d3e462709558f1d0beb7cd5

Is it ok if I just rely on description text to extract it? Is anyone else obviously more capable having an "itch" to check this out? Or, if not, could I ask for some guidelines?

TIA,

Yianni

comment:3 Changed 5 years ago by Stuart Auchterlonie

Milestone: unknown0.28

The correct approach would be to uncomment the ParentalRatingDescriptor? and enhance it if necessary, and then use it within your code.

comment:4 Changed 5 years ago by Stuart Auchterlonie

After looking at it more carefully, the ParentalRatingDescriptor? is only a stub, rather than being commented out.

Essentially all it does is verify the correct table id is set.

So, in this case, you need to enhance the methods in that class, to do whatever work is necessary to parse and use the available data.

I'd suggest implementing the toString() method first so you can see what is actually in the descriptor ;-)

comment:5 Changed 5 years ago by Yianni Vidalis <yiannividalis@…>

To say that it's beyond my current knowledge level would be an understatement! However, thanks for your reply, I'll try to parse the code and compare it to classes that are used. Is there a "qt creator for ... daddies?" If my comments are getting close to locking this ticket, please let me know and I'll stop :)

comment:6 Changed 5 years ago by Stuart Auchterlonie

Not at all. Feel free to ask questions either here on irc #mythtv on freenode

Changed 4 years ago by yiannividalis@…

Attachment: eitfixup-greek.2.diff added

update after e7a20aa

comment:7 Changed 4 years ago by Karl Dietz <dekarl@…>

Resolution: fixed
Status: newclosed

In 989baa7daac162f63201f650ab011e506f03a11f/mythtv:

add fixup for greek EIT

Patch by Yianni Vidalis
Fixes #12436

comment:8 Changed 4 years ago by Karl Egly

Yianni, thank you for the contribution.

I had to make a small adjustment due to collisions in the fixup keys. (kFixGreekSubtitle amd kFixHTML both set to 1 << 27 broke the unit tests, so I found out when running "make test") It would be great if you could add a unit test to test_eitfixups so we don't accidently break it in the future.

comment:9 Changed 4 years ago by Karl Dietz <dekarl@…>

In 109b578ade1f14936f8f72a23c2aa7c3ba8295e3/mythtv:

implement parental_rating_descriptor

Refs #12436
Refs #12553

comment:10 Changed 4 years ago by Karl Dietz <dekarl@…>

In 5daa9e7f0a80fce49de0c22c55249a9ae748c9b1/mythtv:

test 1<<31 vs 1u<<31 in eit fixup flags

Refs #12436

Note: See TracTickets for help on using tickets.