Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#12445 closed Patch - Bug Fix (fixed)

Visualisations do not support 24-bit and 32-bit audio

Reported by: russell@… Owned by: paulh
Priority: minor Milestone: 0.28
Component: Plugin - MythMusic Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

I noticed that the visualizer was rendering garbage whenever I played a vorbis file or a 24-bit flac. It seems that the visualizers require a 16-bit stereo feed, and currently only convert between 8 and 16 bit (mono and stereo). The 24-bit FLAC decoder outputs 32bit signed integers, and the Ogg Vorbis decoder outputs 32 bit float (even for stuff encoded from a 16-bit source). The only way to pick the difference between the two (and choose the correct cast) is that FLAC reports 24-bit, even though both are outputting 32.

I have also stopped it from rendering uninitialised memory for an unsupported sample format, the same way it does when there is an unsupported channel count.

Pull request: https://github.com/MythTV/mythtv/pull/95

Change History (2)

comment:1 Changed 4 years ago by pHr34kY <russell@…>

Resolution: fixed
Status: newclosed

In b6331d71e08a85999f24f4810c5a8344b973f934/mythtv:

MythMusic: Add visualization support for 24 and 32bit audio (mono and stereo)

Also fixes rendering of uninitialised memory for unsupported sample formats.
Fixes #12445

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 4 years ago by paulh

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.