Opened 9 years ago
Closed 4 years ago
#12460 closed Patch - Bug Fix (Fixed)
mythmetadata: data lookup for TV specials fails
| Reported by: | Owned by: | JYA | |
|---|---|---|---|
| Priority: | minor | Milestone: | 29.2 |
| Component: | MythTV - Mythmetadatalookup | Version: | v31-fixes |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
in thetvdb.com specials are season zero. Unfortunately, libmythmetadata has a zero check on the season which ignores season zero set on any file, meaning it never retrieves the correct data for specials.
The fix is only to check if the episode is non zero, not the season and episode
Attachments (1)
Change History (9)
Changed 9 years ago by
| Attachment: | 07_fix_specials.diff added |
|---|
comment:1 Changed 9 years ago by
| Milestone: | unknown → 0.28 |
|---|
comment:2 Changed 9 years ago by
It looks like the change that caused the problem also went into 0.27.4 as
commit af9082ea5a4123662726dbfe58ee3516f9cb75db Author: Jean-Yves Avenard <jyavenard@…> Date: Thu Jul 17 23:33:00 2014 +1000
metadata: complete refactor of search
So the fix probably needs backporting to the 0.27 branch as well (patch applies as is).
comment:5 Changed 7 years ago by
| Milestone: | 29.0 → 29.1 |
|---|
comment:6 Changed 7 years ago by
| Milestone: | 29.1 → 0.28.2 |
|---|
Moving remaining open tickets to 0.28.2 milestone
comment:7 Changed 7 years ago by
| Milestone: | 0.28.2 → 29.2 |
|---|
Moving remaining open tickets to 29.2 milestone
comment:8 Changed 4 years ago by
| Resolution: | → Fixed |
|---|---|
| Status: | new → closed |
| Version: | Unspecified → v31-fixes |
Fixed by commit https://github.com/MythTV/mythtv/commit/8ca546b on master and v31
if (list.isEmpty() && (lookup->GetSeason() || lookup->GetEpisode()))
See pull request: Fix thetvdb Specials #185
fix for the specials problem