Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1249 closed defect (fixed)

Channel surfing may change inert reclist items to rsRecorded.

Reported by: bjm Owned by: bjm
Priority: blocker Milestone: 0.19
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

To reproduce, create or find a show marked as rsPreviousRecording that is currently showing. Enter liveTV and change channels to the station of the show marked as previously recorded. Exit live and go to Upcoming Recordings. This show is now displayed as rsRecorded.

This is only cosmetic. This can be avoided if (curRec->recgroup != "LiveTV") before updating recording status in FinishedRecording?. However, the in memory recgroup is not updated after TOGGLERECORD so it fails to inform the scheduler that a recording has finished when a show was live then transitioned to recording. A low risk solution is not obvious.

I can fix this later. I'm not going to risk new bugs for something cosmetic like this.

Change History (4)

comment:1 Changed 13 years ago by bjm

Summary: Channel surfing may change inactive reclist items to rsRecorded.Channel surfing may change inert reclist items to rsRecorded.

comment:2 Changed 13 years ago by bjm

Milestone: 0.200.19
Priority: trivialblocker
Resolution: fixed
Severity: lowmedium
Status: newclosed

Check that. This is an important issue becase it would leave an rsRecorded entry in oldrecorded which may block a future scheduled recording of the episode. This is a regression from a similar fix a few months ago.

If the recstatus is rsRecording when it is asked to finished, then UPDATE_RECORDING_STATUS . LiveTV will not have a status of rsRecording but the previous status in oldrecorded or rsUnkown.

comment:3 Changed 13 years ago by bjm

(In [8912]) Fixes #1249

If the recstatus is rsRecording when it is asked to finished, then UPDATE_RECORDING_STATUS . LiveTV will not have a status of rsRecording but the previous status in oldrecorded or rsUnkown.

comment:4 Changed 13 years ago by bjm

(In [8913]) Fixes #1249

Checking the recstatus turns out to be unreliable and may not update the oldrecorded status to rsRecorded for real recordings. Instead borrow the approach in CheckForRecGroupChange?() to verify the recgroup stored in the 'recorded' table.

If the real recgroup is not LiveTV when it is asked to finished, then UPDATE_RECORDING_STATUS else skip the update for LiveTV recordings.

Note: See TracTickets for help on using tickets.