Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12490 closed Patch - Feature (fixed)

Trakt.tv episode link on detail mythweb page [Implemented]

Reported by: tv@… Owned by: Karl Egly
Priority: minor Milestone: 0.28
Component: Plugin - MythWeb Version: Unspecified
Severity: medium Keywords: trakt.tv
Cc: Ticket locked: no

Description (last modified by Karl Egly)

I added a link to trakt.tv for a tv episode, just like linking off to the metadata homepage on thetvdb.com. I'm not on github so I didn't submit it there, and I'm not sure how to properply update the language files to it currently yells that there is no translation...

Here's the diff of mythweb/modules/tv/tmpl/default/detail.php

140d139
<          var traktPage = $("trakt-page");
147d145
<              traktPage && Element.remove(traktPage);
149,162d146
<          }
<
<       var episodeID = item.HomePage.match(/.*&id=(\d+)/)[1];
<       var traktHREF = "http://trakt.tv//search/tvdb/" + episodeID + "?id_type=episode"
<
<          // update the link or create it if this item does have a trakt page
<          if (traktPage) {
<               traktPage.href = traktHREF;
<          } else {
<               $($$(".x-links")[0].children[1]).insert({top:
<                   new Element("a",
<                       {href: traktHREF,
<                        target: "mythtwebtrakt", id: "trakt-page"}).
<                       update(item.Title + " " + "<?php echo t("Trakt.tv Home Page") ?>")});

Attachments (1)

mythweb.diff.txt (789 bytes) - added by anonymous 4 years ago.

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by anonymous

Attachment: mythweb.diff.txt added

comment:1 Changed 4 years ago by tv@…

I attached the diff as a file, since it looked terrible in the original post and I don't see how to modify that.

comment:2 Changed 4 years ago by Karl Egly

Description: modified (diff)
Owner: changed from Rob Smith to Karl Egly
Status: newaccepted

comment:3 Changed 4 years ago by Karl Dietz <dekarl@…>

Resolution: fixed
Status: acceptedclosed

In 094b694b712f22fc27ad0fbdf4436e45f90272a6/mythweb:

Add Trakt.tv episode link on detail mythweb page

Patch by Freakeao on our forum.

Fixes #12490

comment:4 Changed 4 years ago by tv@…

This can still use proper localization support.

comment:5 Changed 4 years ago by Karl Egly

Milestone: unknown0.28

Can you be more specific? "Trakt.tv Home Page" is a translatable text and can be translated with the next round of translations like the other new texts.

comment:6 Changed 4 years ago by tv@…

It needs to be translated is what I meant. I do not know where to put the "translated" English so it displays a "NoTrans?" error on the page.

comment:7 Changed 4 years ago by Nicolas Riendeau

Hi tv@lazybum!

Which variant of English are we talking about?

We only accept translations fixes from our translators but I happen to be the maintainer of the Canadian English and US English one...

(If it's the UK one it will have to wait until its maintainer is ready to submit an update or you could run the build_translations.pl script locally but not submit it...)

Please let me know...

Nicolas MythTV developer/translation maintainer

comment:8 Changed 4 years ago by tv@…

All of them. I was not aware of how to add any translations. So the page calls for the translation text, but it is not in any file. I use US English.

comment:9 Changed 4 years ago by Nicolas Riendeau

Hi,

The translation files are updated by running build_translations.pl...

For US English the file is called English.lang and is in the module/_shared/lang directory if I am not mistaken...

I can only update the ones under my responsibility, it is up to the other translator(s) to submit their updates when they see fit. We usually don't update them between revisions, when you are running an unstable version (I see that this was only committed to master which is our development version) it's part of "the game" to have issues such as these.

I currently have a problem with the PC I use to commit but it should hopefully be resolved today so I will update the US English file as soon as I can.

Have a nice day,

Nicolas

Last edited 4 years ago by Nicolas Riendeau (previous) (diff)

comment:10 Changed 4 years ago by Nicolas Riendeau

The US English and Canadian English translations have been updated.

As for the British English translation it will have to wait until its maintainer submits an update.

Have a nice day!

Nick

Note: See TracTickets for help on using tickets.