Opened 3 years ago

Closed 3 years ago

#12576 closed Patch - Feature (fixed)

Additional support for .lrc files

Reported by: Mike Rice <mikerice1969@…> Owned by: paulh
Priority: minor Milestone: 0.28
Component: Plugin - MythMusic Version: Master Head
Severity: low Keywords: lyrics
Cc: Ticket locked: no

Description

I've been testing the filelyrics.py grabber with .lrc files. I've found a few elements that are not handled.

  1. Multiple time codes on a single line:

[02:01.45][02:54.25][04:06.70][04:19.90]I ran so far away

  1. Time codes that are missing the hundredths part:

[00:51]I'll be coming for your love, OK?

  1. Offset codes: [offset:+/- Overall timestamp adjustment in milliseconds, + shifts time up, - shifts down]

[offset:500]

  1. Some other tags to ignore:

[id: fu_qkqu] [length: 01:59] [au: BRUCE SPRINGSTEEN]

I've attached a patch that seems to work okay for me.

Attachments (1)

lrc_addition.patch (4.3 KB) - added by Mike Rice <mikerice1969@…> 3 years ago.
patch

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by Mike Rice <mikerice1969@…>

Attachment: lrc_addition.patch added

patch

comment:1 Changed 3 years ago by paulh

Milestone: unknown0.28
Status: newaccepted
Version: UnspecifiedMaster Head

comment:2 Changed 3 years ago by Mike Rice <mikerice1969@…>

Resolution: fixed
Status: acceptedclosed

In 995a7719893ef440fe64008c6c3dd52fa6b57f29/mythtv:

MythMusic: Improve the lyrics file parser

  • handle repeated time codes
  • handle time codes without the hundreds part
  • handle [offset] tags
  • ignore some more tags

Closes #12576

Signed-off-by: Paul Harrison <pharrison@…>

Note: See TracTickets for help on using tickets.