Opened 8 years ago
Closed 8 years ago
Last modified 8 years ago
#12633 closed Bug Report - General (fixed)
EIT fixup for Law & Order: Special Victims Unit needed (Freesat UK)
Reported by: | Owned by: | Karl Egly | |
---|---|---|---|
Priority: | minor | Milestone: | 0.27.7 |
Component: | MythTV - EIT | Version: | 0.27.5 |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Some showings of SVU have the correct title "Law & Order: Special Victims Unit" and some have the title "Law & Order" and the subtitle "Special Victims Unit". As it's inconsistent, I suspect the problem is outside MythTV but hopefully it can be fixed in a fixup. Here are the upcoming showings from my program table:
mysql> SELECT title, subtitle, starttime FROM program WHERE starttime>NOW() AND title LIKE 'Law & Order%' AND (title LIKE '%Special Victims Unit' OR subtitle LIKE 'Special Victims Unit'); +-----------------------------------+----------------------+---------------------+ | title | subtitle | starttime | +-----------------------------------+----------------------+---------------------+ | Law & Order | Special Victims Unit | 2016-02-05 23:00:00 | | Law & Order | Special Victims Unit | 2016-02-06 00:00:00 | | Law & Order | Special Victims Unit | 2016-02-09 21:00:00 | | Law & Order | Special Victims Unit | 2016-02-09 22:00:00 | | Law & Order: Special Victims Unit | Sugar | 2016-02-06 23:25:00 | | Law & Order: Special Victims Unit | Sugar | 2016-02-07 00:25:00 | | Law & Order: Special Victims Unit | Sugar | 2016-02-07 23:25:00 | | Law & Order: Special Victims Unit | Unstable | 2016-02-06 22:30:00 | | Law & Order: Special Victims Unit | Unstable | 2016-02-06 23:30:00 | | Law & Order: Special Victims Unit | Unstable | 2016-02-07 22:30:00 | | Law & Order: Special Victims Unit | Wet | 2016-02-04 22:00:00 | | Law & Order: Special Victims Unit | Wet | 2016-02-04 23:00:00 | | Law & Order: Special Victims Unit | Wet | 2016-02-09 22:00:00 | | Law & Order: Special Victims Unit | Wet | 2016-02-09 23:00:00 | +-----------------------------------+----------------------+---------------------+
Change History (9)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
At stuarta's request...
mysql> select chanid, serviceid, transportid, networkid, d.mplexid from channel as c, dtv_multiplex as d where c.mplexid=d.mplexid and chanid in (select chanid from program where title like 'Law & Order%' and subtitle='Special Victims Unit'); +--------+-----------+-------------+-----------+---------+ | chanid | serviceid | transportid | networkid | mplexid | +--------+-----------+-------------+-----------+---------+ | 3021 | 12992 | 12294 | 9018 | 116 | | 8710 | 7710 | 2057 | 2 | 38 | | 8711 | 7711 | 2057 | 2 | 38 | +--------+-----------+-------------+-----------+---------+
comment:3 Changed 8 years ago by
Okay, similar result to my set
mysql> select chanid, serviceid, transportid, networkid, d.mplexid from channel as c, dtv_multiplex as d where c.mplexid=d.mplexid and chanid in (select chanid from program where title like 'Law & Order%' and subtitle='Special Victims Unit'); +--------+-----------+-------------+-----------+---------+ | chanid | serviceid | transportid | networkid | mplexid | +--------+-----------+-------------+-----------+---------+ | 3021 | 12992 | 12294 | 9018 | 3 | | 5083 | 41344 | 40960 | 9018 | 14 | | 9711 | 7711 | 2057 | 2 | 48 | | 9710 | 7710 | 2057 | 2 | 48 | +--------+-----------+-------------+-----------+---------+ 4 rows in set (0.00 sec)
comment:4 Changed 8 years ago by
Your problem is in eitfixup.cpp line 855ff (fixes/0.27). Since your EIT does not contain any date or year and has ":" in the title it gets split but only if the description does not contain a ":". That's where your two examples differ.
I suggest adding
&& !event.title.startsWith("Law & Order:")
to eitfixup.cpp line 812
comment:5 Changed 8 years ago by
Unit Test for it ...
void TestEITFixups::testUKLawAndOrder() { EITFixUp fixup; DBEventEIT *event = SimpleDBEventEIT (EITFixUp::kFixUK, "Law & Order: Special Victims Unit", "", "Crime drama series. Detective Cassidy is accused of raping ..."); PRINT_EVENT(*event); fixup.Fix(*event); PRINT_EVENT(*event); QCOMPARE(event->title, QString("Law & Order: Special Victims Unit")); QCOMPARE(event->subtitle, QString("")); DBEventEIT *event2 = SimpleDBEventEIT (EITFixUp::kFixUK, "Law & Order: Special Victims Unit", "", "Sugar: New. Police drama series about an elite sex crime ..."); PRINT_EVENT(*event2); fixup.Fix(*event2); PRINT_EVENT(*event2); QCOMPARE(event2->title, QString("Law & Order: Special Victims Unit")); QCOMPARE(event2->subtitle, QString("Sugar")); }
comment:7 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:9 Changed 8 years ago by
Milestone: | unknown → 0.27.7 |
---|
At dekarl's request, here are a couple of samples from
dvbsnoop
. First, from an event where the title is being split:And now from an event where the subtitle is included in the description so all works correctly: