Opened 5 years ago

Closed 4 months ago

#12742 closed Patch - Feature (Fixed)

Feature patch: Parse and insert XMLTV categories as genres for mythfilldatabase

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 31.1
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


Feature patch: Parse and insert XMLTV categories as genres (equivalent to DataDirect? processing) in mythfilldatabase

MythTV has the concept of a (single) category (and a category_type) in the program record, and a programgenres table for genres. XMLTV has a concept of categories for a program, which is a list. While categories and genres are not necessarily the same, they serve a somewhat equivalent purpose. And the existing DataDirect? load treats the available categories from its source to be MythTV genres. While not all XMLTV grabbers provide a category list, some do (uk_atlas is one example), and being able to preserve and use that information seems to be desirable (note that those grabbers that provide at most one category are well handled without this patch).

After applying these patches, those sources which provide additional categories via XMLTV will have that data available for processing via the programgenres table (power search rules?).

The patches are separated so that they may be more easily reviewed by the developers. While they have been compile tested one after the other, they have only been fully tested with real data as a complete set.

Since this is a new capability, I have not created an additional patch to disable the inserting of the data as a new option for mythfilldatabase. If the developer reviewing the patches feels that such a capability is needed before accepting these patches, I can look at the best way to accomplish that.

As an aside, having the programgenres table have a column named "relevance" which is a single character used to insure the key is unique does not seem optimal. I presume there is a well thought out history there that I have not been able to follow.

Note that patch 0 (when applied) will require the committer to bump the ABI version (not included in the patch set because the patches may sit in review for some time, and one nominally wants the ABI version to reflect the commit date).

Patch 0: Field definition in DBEvent:

github ref:

github git-am ref:

Patch 1: Add parsed categories to the genres list

github ref:

github git-am ref:

Patch 2: Insert any collected genres into the database

github ref:

github git-am ref:

Change History (2)

comment:1 Changed 4 months ago by Gary Buhrmaster

I believe this ticket can be closed. The patches (with some changes) were applied at one point in the past by Mr. Poet.

comment:2 Changed 4 months ago by gigem

Milestone: unknown31.1
Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.