Opened 6 years ago

Closed 4 years ago

#13026 closed Patch - Bug Fix (fixed)

Clean up technical debt from Qt4 changes

Reported by: David Hampton <mythtv@…> Owned by: David Hampton
Priority: minor Milestone: 30.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Changes from Qt3 to Qt4 removed the need to explicitly call the detach or copy functions on qt classes. These will be called internally as necessary. See ​http://doc.qt.io/qt-4.8/porting4.html

Change History (9)

comment:1 Changed 6 years ago by David Hampton <mythtv@…>

Patches are at ​https://github.com/MythTV/mythtv/pull/135

comment:2 Changed 6 years ago by stuartm

This particular area should be treated with caution, although there were areas with QT4 where we apparently didn't need to call detach according to the manual, failing to do so lead to lots of subtle and not so subtle bugs.

QT just didn't always do the right thing without being explicit about it. Daniel K was the real expert on this topic, having spent a lot time debugging the problem, so my understanding is limited but he did write an in-depth guide on the subject, I just can't find it at the present.

Last edited 6 years ago by stuartm (previous) (diff)

comment:3 Changed 6 years ago by David Hampton

Owner: set to David Hampton
Status: new → accepted

comment:4 Changed 6 years ago by Stuart Auchterlonie

Milestone: 29.0 → 29.1

comment:5 Changed 5 years ago by Stuart Auchterlonie

Milestone: 29.1 → 0.28.2

Moving remaining open tickets to 0.28.2 milestone

comment:6 Changed 5 years ago by Stuart Auchterlonie

Milestone: 0.28.2 → 29.2

Moving remaining open tickets to 29.2 milestone

comment:7 Changed 5 years ago by David Hampton

Owner: changed from David Hampton to David Hampton
Status: accepted → assigned

comment:8 Changed 4 years ago by David Hampton

Milestone: 29.2 → 30.0

comment:9 Changed 4 years ago by David Hampton <mythtv@…>

Resolution: → fixed
Status: assigned → closed

In 5edd847b1/mythtv:

Remove unnecessary calls to the copy() function.

According to the Qt3 to Qt4 porting document
(​http://doc.qt.io/qt-4.8/porting4.html) all classes are now implicitly
shared. That means there is no longer a needto call copy() on any qt
classes.

Fixes #13026.

Note: See TracTickets for help on using tickets.