Opened 22 months ago

Closed 22 months ago

#13060 closed Bug Report - General (Invalid)

Duplicate definition error in recorders/v4lchannel.cpp causes compile fail

Reported by: newbury@… Owned by:
Priority: minor Milestone: unknown
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Compile of master June 26. 2017 (? e0d15446e7df50ec5f671a068a4e4392c54fe628 ?) fails with a duplicate definition error, due to duplicate inclusion of 'videodev2.h' from kernel headers.

In mythtv/libs/libmythtv/recorders/v4lchannel.cpp

Line 19: #include <linux/videodev2.h> duplicates the include in Line 9 of v4lchannel.h
#include <linux/videodev2.h>

The fix is to comment out the include line in v4lchannel.cpp

-- #include <linux/videodev2.h>

++ #include <linux/videodev2.h>

Or delete the entire line in v4lchannel.cpp.

(No idea why this shows up now: this part of the file has not been touched for years!)

Change History (3)

comment:1 Changed 22 months ago by Gary Buhrmaster <gary.buhrmaster@…>

linux/videodev2.h is protected internally (as is typical for all such includes) by an ifdef. Are your headers (or include path) non-standard? Also note no such error was reported by any buildbot slave.

comment:2 Changed 22 months ago by Bill Meek <keemllib@…>

And note that commit e0d15446e7df50ec5f671a068a4e4392c54fe628 is from Fri Nov 4 2016. Most recent changeset: v29-pre-511-g4dc5ef3

comment:3 Changed 22 months ago by Peter Bennett

Resolution: Invalid
Status: newclosed
Note: See TracTickets for help on using tickets.