metadata lookup is invoking invalid executables

[Peter Bennett]

When refreshing artwork as follows

mythmetadatalookup --refresh-all-artwork --verbose general,system 

Some invalid things are showing up in the logs

2017-08-25 18:10:14.576191 I [16729/16729] CoreContext mythsystemunix.cpp:948 (Fork) - Managed child (PID: 16784) has started! * command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Television/tvdb_test.conf -v, timeout=0
2017-08-25 18:10:14.596324 I [16729/16750] SystemManager mythsystemunix.cpp:354 (run) - Managed child (PID: 16784) has exited! command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Television/tvdb_test.conf -v, status=32256, result=126
2017-08-25 18:10:14.626164 I [16729/16729] CoreContext mythsystemunix.cpp:948 (Fork) - Managed child (PID: 16786) has started! * command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Musicmbutils.py -v, timeout=0
2017-08-25 18:10:14.646305 I [16729/16750] SystemManager mythsystemunix.cpp:354 (run) - Managed child (PID: 16786) has exited! command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Musicmbutils.py -v, status=32512, result=127

The file tvdb_test.conf that it is trying to run is not an executable. The file Musicmbutils.py has a slash missing, it should be Music/mbutils.py. Apart from these errors the run appears to work correctly.

[anonymous]

Fixes the tvdb_test.conf error, but QDir::Executable filter won't work for Windows

[Peter Bennett]

Who is the author of that patch? It posted as anonymous.

If we are fixing this we should also address the missing slash in the name Musicmbutils.py, or stop the code from looking at the Music directory, whichever is appropriate.

[Bill Meek <keemllib@…>]

The patch is mine just forgot to change the Author box, Bill.

I was trying to find out where the .conf file was being selected since it didn't happen without --refresh-all.

I'm not seeing the Music Brains error, must be something I don't have configured. Looking at line 72 in the same file as the patch, maybe a trailing slash need to be added there?

[Peter Bennett]

Updated fix for this that includes fixing the way the file name is constructed so that it creates a valid file name for the music grabber. Also added a timeout to the grabber of 60 seconds. I experienced an occasion where --refresh-all-artwork hung for an hour, preventing backend shutdown.

Note that the Music/mbutils.py program is not marked executable. To ensure that it will be run I will mark it executable

[Peter Bennett]

Updated patch, see comments

[Peter Bennett <pbennett@…>]

In bc023f40efa32f7731fe59c300d85cbd9dadada2/mythtv:

mythmetadatalookup: fix accessing invalid executables, add a timeout

Fixes #13111