Opened 2 years ago

Closed 2 years ago

Last modified 16 months ago

#13111 closed Bug Report - General (fixed)

metadata lookup is invoking invalid executables

Reported by: Peter Bennett Owned by: Peter Bennett
Priority: minor Milestone: 30.0
Component: MythTV - Mythmetadatalookup Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When refreshing artwork as follows

mythmetadatalookup --refresh-all-artwork --verbose general,system 

Some invalid things are showing up in the logs

2017-08-25 18:10:14.576191 I [16729/16729] CoreContext mythsystemunix.cpp:948 (Fork) - Managed child (PID: 16784) has started! * command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Television/tvdb_test.conf -v, timeout=0
2017-08-25 18:10:14.596324 I [16729/16750] SystemManager mythsystemunix.cpp:354 (run) - Managed child (PID: 16784) has exited! command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Television/tvdb_test.conf -v, status=32256, result=126
2017-08-25 18:10:14.626164 I [16729/16729] CoreContext mythsystemunix.cpp:948 (Fork) - Managed child (PID: 16786) has started! * command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Musicmbutils.py -v, timeout=0
2017-08-25 18:10:14.646305 I [16729/16750] SystemManager mythsystemunix.cpp:354 (run) - Managed child (PID: 16786) has exited! command=/home/peter/proj/build/xenial-amd64/mythtv/ttvdb/usr/share/mythtv/metadata/Musicmbutils.py -v, status=32512, result=127

The file tvdb_test.conf that it is trying to run is not an executable. The file Musicmbutils.py has a slash missing, it should be Music/mbutils.py. Apart from these errors the run appears to work correctly.

Attachments (2)

13111.2017.08.26.v0.conf.patch (763 bytes) - added by anonymous 2 years ago.
Fixes the tvdb_test.conf error, but QDir::Executable filter won't work for Windows
20170912_grabber.patch (1.6 KB) - added by Peter Bennett 2 years ago.
Updated patch, see comments

Download all attachments as: .zip

Change History (9)

Changed 2 years ago by anonymous

Fixes the tvdb_test.conf error, but QDir::Executable filter won't work for Windows

comment:1 Changed 2 years ago by Peter Bennett

Owner: changed from JYA to Peter Bennett
Status: newassigned

Who is the author of that patch? It posted as anonymous.

If we are fixing this we should also address the missing slash in the name Musicmbutils.py, or stop the code from looking at the Music directory, whichever is appropriate.

comment:2 Changed 2 years ago by Bill Meek <keemllib@…>

The patch is mine just forgot to change the Author box, Bill.

I was trying to find out where the .conf file was being selected since it didn't happen without --refresh-all.

I'm not seeing the Music Brains error, must be something I don't have configured. Looking at line 72 in the same file as the patch, maybe a trailing slash need to be added there?

comment:3 Changed 2 years ago by Stuart Auchterlonie

Milestone: needs_triage30.0

comment:4 Changed 2 years ago by Peter Bennett

Updated fix for this that includes fixing the way the file name is constructed so that it creates a valid file name for the music grabber. Also added a timeout to the grabber of 60 seconds. I experienced an occasion where --refresh-all-artwork hung for an hour, preventing backend shutdown.

Note that the Music/mbutils.py program is not marked executable. To ensure that it will be run I will mark it executable

Changed 2 years ago by Peter Bennett

Attachment: 20170912_grabber.patch added

Updated patch, see comments

comment:5 Changed 2 years ago by Peter Bennett

Status: assignedaccepted

comment:6 Changed 2 years ago by Peter Bennett <pbennett@…>

Resolution: fixed
Status: acceptedclosed

In bc023f40efa32f7731fe59c300d85cbd9dadada2/mythtv:

mythmetadatalookup: fix accessing invalid executables, add a timeout

Fixes #13111

comment:7 Changed 16 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.