Opened 7 years ago
Closed 7 years ago
#13122 closed Patch - Feature (Fixed)
Qt 5.10 compatibility
| Reported by: | Owned by: | David Hampton | |
|---|---|---|---|
| Priority: | minor | Milestone: | 30.0 |
| Component: | Qt5 issues | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
As part of a review of my pending WIP stashes to determine if any might have value to the project, I provide the following patches for your consideration.....
Background: The Qt projects current plan is that they will be releasing a 5.10 and a 5.11 version at some point reasonably soon. And Qt 6.x will likely see the light of day sometime in 2019. At this point, Qt 6, while having a major number increase, is expected to be "mostly" source compatible with 5.x, not that that will really be understood for a bit longer.
While most of the checks in the actual code use the appropriate macros for version checking (greater than version 050000), the existing checks in the .pro files and the configure file only support up to a Qt 5.9 release (single digit checks for 5.x). The project needs to consider the 5.10 and 5.11 series.
Summary of changes.
As MythTV now requires Qt 5.2, eliminate the conditional checks for Qt 5.x in the .pro files (always include the newer requirements), and remove the tolerance for legacy Qt 4.x. Make the version checking in configure for >= 5.2 a bit more complete and tolerant (and maybe make it slightly easier to bump the requirement to some future 5.x level).
This is provided in multiple patch sets so that one can more easily review the changes.
While the patches were targeted to master, if accepted, this patch set is likely going to be needed to be cherrypicked to fixes/29.
I have (once in the past) done a compile with these patches, but no operational testing was performed.
Attachments (5)
Change History (9)
Changed 7 years ago by
| Attachment: | qt510-configure.patch added |
|---|
comment:1 Changed 7 years ago by
| Milestone: | needs_triage → 30.0 |
|---|---|
| Owner: | set to Stuart Auchterlonie |
| Status: | new → accepted |
comment:2 Changed 7 years ago by
Apologies, I had left some version testing code in the configure patch, and had missed including the mythplugins configure changes (I all too often forget about the plugins), which are essentially the same as the main configure changes. Updating patch was attached.
comment:3 Changed 7 years ago by
| Owner: | changed from Stuart Auchterlonie to David Hampton |
|---|---|
| Status: | accepted → assigned |
comment:4 Changed 7 years ago by
| Resolution: | → Fixed |
|---|---|
| Status: | assigned → closed |
Fixed in master by 3d580948cf, in 29 by 771115f47d, and in 0.28 by ecae169e69.
patch for configure