Opened 2 years ago

Closed 2 years ago

Last modified 21 months ago

#13133 closed Patch - Feature (fixed)

Improve the Video playback profile setup

Reported by: Peter Bennett Owned by: Peter Bennett
Priority: minor Milestone: 30.0
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Video profiles can specify video sizes as a way of selecting playback parameters. Up to now there have been two sets of height and width settings with a comparison operator for each.

It is not clear to most people if you select 800x600, whether a video that is 900x500 is greater, less or equal. Is is not clear why you even have to specify both width and height, selecting based on height alone may be more appropriate - that is the way videos are categorized - as 480 720 or 1080, without worrying about the width as well.

It is not clear why you need two sets of width and height. It is presumably to specify a range. However you can have different profiles based on ranges just by ordering them logically, for example the first entry for <=480, the next for <=720 and the last with no criteria. The system always searches these sequentially so that, for example, the second entry effectively has a criterion of 481-720.

With this change there are two input boxes for "Width Range" and "Height Range" to replace the two sets of height and width conditions. This way they can be seen together on the edit page and it is clear what is being done. Each box can be left empty or can have either a range specified, for example 481-720, or a criterion such as <=720. You can specify height settings without width settings or vice versa.

This ticket is a follow up to #13061, in that part of the change was already done there when catering for framerate ranges.

The width and height conditions are stored in a new format in the database. The old format is still recognized and converted by the code when loading the profiles. There is no schema update for this.

Note that if you have changed a profile and then go back to an earlier version of mythfrontend without this change, the profile editor will not find the size settings on profiles that were changed.

Attachments (1)

20170924_videoprofiles.patch (27.8 KB) - added by Peter Bennett 2 years ago.
Patch to implement this feature

Download all attachments as: .zip

Change History (5)

Changed 2 years ago by Peter Bennett

Patch to implement this feature

comment:1 Changed 2 years ago by Peter Bennett

There are also some improvements in the database. The table displayprofiles will no longer have rows for empty parameters and the redundant setting "> 0 0" that is used in almost all profiles is being removed. The selection of width and height is now optional and we do not need to supply the default setting of "> 0 0".

comment:2 Changed 2 years ago by Peter Bennett

Status: newaccepted

comment:3 Changed 2 years ago by Peter Bennett <pbennett@…>

Resolution: fixed
Status: acceptedclosed

In 664674845d5214a907c8e0b51d8db1ef7d8f86a6/mythtv:

Settings: Improved Video Playback Profile setup

Simplify the setup and checking of video size in selection of
playback profile.

Fixes #13133

comment:4 Changed 21 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.