Opened 2 years ago

Closed 23 months ago

Last modified 20 months ago

#13204 closed Patch - Bug Fix (fixed)

Time consuming entry of numeric fields in new setup

Reported by: klaas.de.waal@… Owned by: Peter Bennett
Priority: minor Milestone: 29.2
Component: MythTV - Mythtv-setup Version: Master Head
Severity: low Keywords: dvb dvb-c network-id
Cc: Ticket locked: no

Description

When creating a new Video Source the Network ID can only be changed with arrow buttons. It is not possible to directly enter the required value. This is inconvenient when the default value of -1 has to be changed to e.g. 5555.

The attached patch changes the UI element from spinbox to text so that the value can be entered directly.

File: libs/libmythtv/videosource.cpp

Attachments (3)

videosource.cpp.patch (1.6 KB) - added by klaas.de.waal@… 2 years ago.
patch for Network ID entry field
20180507_1907_spinbox.patch (8.7 KB) - added by Peter Bennett 2 years ago.
Patch for new dialog to allow typing values into a spinbox
20180508_1726_spinbox.patch (8.8 KB) - added by Peter Bennett 2 years ago.
Updated patch with a change to the title of the entry dialog

Download all attachments as: .zip

Change History (18)

Changed 2 years ago by klaas.de.waal@…

Attachment: videosource.cpp.patch added

patch for Network ID entry field

comment:1 Changed 2 years ago by Peter Bennett

Owner: changed from JYA to Peter Bennett
Status: newassigned

Did you try page up/ Page Down in the spinbox? That will advance by a greater increment. The default is 8. In the code you could change

min_val, 0xffff, 1)

to

min_val, 0xffff, 1, 100)

to make it increment by 100 with page up/page down, and still by 1 with arrow left / arrow right.

Last edited 2 years ago by Peter Bennett (previous) (diff)

comment:2 Changed 2 years ago by klaas.de.waal@…

No. But it would still require 5555/8 is about 600 keyclicks, or 5555/100+55 is about 110 keyclicks to enter the value 5555.

comment:3 Changed 2 years ago by Peter Bennett

You can hold the button for very fast incrementing.

I tested this. I had network id as -1. I hold the page-down button while the numbers increment, then stop as soon as I see something around 5555. Timed on a stopwatch - 35 seconds. It stopped at 5527, so a few more presses brings me to 5555. Less than 1 minute. Only 2 or 3 "key clicks" although 1 of them was a 35-second "key-click".

comment:4 Changed 2 years ago by Peter Bennett

Status: assignedaccepted

comment:5 Changed 2 years ago by Stuart Auchterlonie

Milestone: needs_triage30.0

comment:6 Changed 2 years ago by Peter Bennett

comment:7 Changed 2 years ago by Peter Bennett

Summary: Cannot enter value for DVB-C Network ID in video sourceTime consuming entry of numeric fields in new setup

comment:8 Changed 2 years ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Status: acceptedassigned

Changed 2 years ago by Peter Bennett

Attachment: 20180507_1907_spinbox.patch added

Patch for new dialog to allow typing values into a spinbox

comment:9 Changed 2 years ago by Peter Bennett

Attached patch allows for typed entry into any spinbox in the system, including those on the front end. Pressing enter or a number button or key into a spinbox opens a dialog where you can type any number that is valid for the spinbox. If a number is not valid for the spinbox the "OK" button is disabled.

Changed 2 years ago by Peter Bennett

Attachment: 20180508_1726_spinbox.patch added

Updated patch with a change to the title of the entry dialog

comment:10 Changed 23 months ago by Peter Bennett <pb.mythtv@…>

Resolution: fixed
Status: assignedclosed

In ccbded85c/mythtv:

Setup: Support typed input into any spinbox

Allows for typed entry into any spinbox in the system, including those
on the front end. Pressing enter or a number button or key into a
spinbox opens a dialog where you can type any number that is valid
for the spinbox. If a number is not valid for the spinbox
the "OK" button is disabled.

Fixes #13204

(cherry picked from commit 862e510f589e3fedb8f37b61ac7967a219b7d8f4)

comment:11 Changed 23 months ago by Peter Bennett <pb.mythtv@…>

In 862e510f5/mythtv:

Setup: Support typed input into any spinbox

Allows for typed entry into any spinbox in the system, including those
on the front end. Pressing enter or a number button or key into a
spinbox opens a dialog where you can type any number that is valid
for the spinbox. If a number is not valid for the spinbox
the "OK" button is disabled.

Fixes #13204

comment:12 Changed 23 months ago by Peter Bennett

Milestone: 30.029.2

comment:13 Changed 20 months ago by Peter Bennett <pb.mythtv@…>

In ccbded85c/mythtv:

Setup: Support typed input into any spinbox

Allows for typed entry into any spinbox in the system, including those
on the front end. Pressing enter or a number button or key into a
spinbox opens a dialog where you can type any number that is valid
for the spinbox. If a number is not valid for the spinbox
the "OK" button is disabled.

Fixes #13204

(cherry picked from commit 862e510f589e3fedb8f37b61ac7967a219b7d8f4)

comment:14 Changed 20 months ago by Peter Bennett <pb.mythtv@…>

In 862e510f5/mythtv:

Setup: Support typed input into any spinbox

Allows for typed entry into any spinbox in the system, including those
on the front end. Pressing enter or a number button or key into a
spinbox opens a dialog where you can type any number that is valid
for the spinbox. If a number is not valid for the spinbox
the "OK" button is disabled.

Fixes #13204

comment:15 Changed 20 months ago by Peter Bennett <pbennett@…>

In b46a64f08/mythtv:

Fix error in theme used by spinbox enhancement

commit ccbded85c9bff6 added the ability to type spinbox input.
The theme xml for that used a feature that is only available in master
so it did not work in v29. This downgrades the default theme file
to be v29 compatible.

Refs #13204

Note: See TracTickets for help on using tickets.