Opened 7 years ago
Closed 7 years ago
Last modified 7 years ago
#13204 closed Patch - Bug Fix (fixed)
Time consuming entry of numeric fields in new setup
Reported by: | Owned by: | Peter Bennett | |
---|---|---|---|
Priority: | minor | Milestone: | 29.2 |
Component: | MythTV - Mythtv-setup | Version: | Master Head |
Severity: | low | Keywords: | dvb dvb-c network-id |
Cc: | Ticket locked: | no |
Description
When creating a new Video Source the Network ID can only be changed with arrow buttons. It is not possible to directly enter the required value. This is inconvenient when the default value of -1 has to be changed to e.g. 5555.
The attached patch changes the UI element from spinbox to text so that the value can be entered directly.
File: libs/libmythtv/videosource.cpp
Attachments (3)
Change History (18)
Changed 7 years ago by
Attachment: | videosource.cpp.patch added |
---|
comment:1 Changed 7 years ago by
Owner: | changed from JYA to Peter Bennett |
---|---|
Status: | new → assigned |
Did you try page up/ Page Down in the spinbox? That will advance by a greater increment. The default is 8. In the code you could change
min_val, 0xffff, 1)
to
min_val, 0xffff, 1, 100)
to make it increment by 100 with page up/page down, and still by 1 with arrow left / arrow right.
comment:2 Changed 7 years ago by
No. But it would still require 5555/8 is about 600 keyclicks, or 5555/100+55 is about 110 keyclicks to enter the value 5555.
comment:3 Changed 7 years ago by
You can hold the button for very fast incrementing.
I tested this. I had network id as -1. I hold the page-down button while the numbers increment, then stop as soon as I see something around 5555. Timed on a stopwatch - 35 seconds. It stopped at 5527, so a few more presses brings me to 5555. Less than 1 minute. Only 2 or 3 "key clicks" although 1 of them was a 35-second "key-click".
comment:4 Changed 7 years ago by
Status: | assigned → accepted |
---|
comment:5 Changed 7 years ago by
Milestone: | needs_triage → 30.0 |
---|
comment:7 Changed 7 years ago by
Summary: | Cannot enter value for DVB-C Network ID in video source → Time consuming entry of numeric fields in new setup |
---|
comment:8 Changed 7 years ago by
Owner: | changed from Peter Bennett to Peter Bennett |
---|---|
Status: | accepted → assigned |
Changed 7 years ago by
Attachment: | 20180507_1907_spinbox.patch added |
---|
Patch for new dialog to allow typing values into a spinbox
comment:9 Changed 7 years ago by
Attached patch allows for typed entry into any spinbox in the system, including those on the front end. Pressing enter or a number button or key into a spinbox opens a dialog where you can type any number that is valid for the spinbox. If a number is not valid for the spinbox the "OK" button is disabled.
Changed 7 years ago by
Attachment: | 20180508_1726_spinbox.patch added |
---|
Updated patch with a change to the title of the entry dialog
comment:10 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In ccbded85c/mythtv:
comment:12 Changed 7 years ago by
Milestone: | 30.0 → 29.2 |
---|
patch for Network ID entry field