Opened 23 months ago

Closed 8 months ago

Last modified 8 months ago

#13215 closed Patch - Feature (fixed)

Patch for Finnish EIT weirdness

Reported by: dag@… Owned by: Dag Nygren <dag@…>
Priority: minor Milestone: 29.2
Component: MythTV - General Version: v29-fixes
Severity: medium Keywords: Finnish EIT
Cc: Ticket locked: no

Description

Finnish EIT info for most channels will have an added (<age limit>) at the end of the title. Additionally this can change between different episodes. This is very bad for scheduling and I created a patch for eitfixup to remove this.

The patch also removes the disturbing Film: or Elokuva: that is used in the title of some movies and makes it really hard to find them later in the listings.

Attachments (4)

finnish-eit.patch (1.7 KB) - added by dag@… 23 months ago.
Patch for eitfixup fixing Finnish EIT
finnish-eit.2.patch (1.7 KB) - added by dag@… 22 months ago.
Fixed patch
eitfixup.cpp.diff (1.3 KB) - added by dag@… 22 months ago.
FIx for too loose regexp
finnish-eit.3.patch (1.8 KB) - added by dag@… 22 months ago.
Sorry, wrong file uploaded disregard previous one. This is the real one

Download all attachments as: .zip

Change History (13)

Changed 23 months ago by dag@…

Attachment: finnish-eit.patch added

Patch for eitfixup fixing Finnish EIT

Changed 22 months ago by dag@…

Attachment: finnish-eit.2.patch added

Fixed patch

comment:1 Changed 22 months ago by dag@…

Fxed the patch not to react to a year in parenthesis at the end of the title

comment:2 Changed 22 months ago by dag@…

Still modified the regexp not even to accept (1T) nor (1S).

This is as good as we can get.

Changed 22 months ago by dag@…

Attachment: eitfixup.cpp.diff added

FIx for too loose regexp

Changed 22 months ago by dag@…

Attachment: finnish-eit.3.patch added

Sorry, wrong file uploaded disregard previous one. This is the real one

comment:3 Changed 22 months ago by Stuart Auchterlonie

Milestone: needs_triage29.2
Version: Unspecifiedv29-fixes

comment:4 Changed 10 months ago by dagnygren

Just check out 0.30-fixes and had to reapply this patch. Could someone commit it please?

comment:5 Changed 8 months ago by Jarno Suni

I think "Elokuva:" (or "Film:", which I did not find examples of) can help in finding films in listings by Mythtv frontend and by Kodi (which has more advanced program search). BTW Yle channels use "Kino:", "Kino Suomi:" and "Uusi Kino:" How would you distinguish movies from series and other programs without such prefixes? I think duplicate matching could be improved to be more flexible by allowing some editing of fields by user defined regular expressions before comparing them.

comment:6 Changed 8 months ago by dagnygren

  1. Film or Elokuva depends on your language settings as we have two official languages in Finland
  1. A title is a title in my opinion and should not be messed with by the broadcaster. There is a category in the EIT (and in Mythtv) that should be used for telling if it is a series or a movie - And a lot of other things, but the broadcasters in Finland doesn't seem aware of it. There is also a unique ID in there, but that also to have been overlooked as it is empty in Finland.What we might be able to do is to force the category to Movie when we see these weird additions to the title. Feel free to expand the patch! And I might also expand it with the Kino-stuff when it starts irritating me enough ;-)

comment:7 Changed 8 months ago by Dag Nygren <dag@…>

Owner: set to Dag Nygren <dag@…>
Resolution: fixed
Status: newclosed

In 753a062b1/mythtv:

Update Finish EIT fixups.

1) Remove 'Film' or 'Elokuva' at the start of titles. 2) Remove age
limit at the end of the title.

Fixes #13215.

Signed-off-by: David Hampton <mythtv@…>

comment:8 Changed 8 months ago by Dag Nygren <dag@…>

In 4d9959418/mythtv:

Update Finish EIT fixups.

1) Remove 'Film' or 'Elokuva' at the start of titles. 2) Remove age
limit at the end of the title.

Fixes #13215.

Signed-off-by: David Hampton <mythtv@…>
(cherry picked from commit 753a062b10d93485830a4dbf7a52d8336e2edf96)

comment:9 Changed 8 months ago by Jarno Suni

Now how do you search for upcoming films in those Finnish channels? Many series are listed as films in parenthesis in guide. Can you still see the age limit on guide, for example?

Note: See TracTickets for help on using tickets.