Opened 12 months ago

Closed 12 months ago

Last modified 9 months ago

#13262 closed Patch - Bug Fix (fixed)

Freetype2 v.2.9.1 deprecates freetype-configure, breaking the config script

Reported by: Taijian Owned by: Peter Bennett
Priority: major Milestone: 29.2
Component: MythTV - configure script Version: v29.1
Severity: high Keywords:
Cc: Ticket locked: no

Description

Arch Linux updated to freetype2 v.2.9.1 on May 2nd, introducing a change that confuses and breaks MythTV's configure script, because as of v2.9.1 freetype2 deprecates the 'freetype-config' command, which is used in several places by configure.

A proposed patch is attached and builds on my system (Arch Linux as of May 3rd, 2018).

Attachments (3)

freetype2.patch (1.5 KB) - added by Taijian 12 months ago.
patch to fix building with freetype2 v2.9.1+
20180509_1445_configure_v29_freetype.patch (2.8 KB) - added by Peter Bennett 12 months ago.
Fix backported from master
20180509_1744_configure_v29_freetype.patch (3.2 KB) - added by Peter Bennett 12 months ago.
Amended patch with additional fix for freetype-config

Download all attachments as: .zip

Change History (13)

Changed 12 months ago by Taijian

Attachment: freetype2.patch added

patch to fix building with freetype2 v2.9.1+

comment:1 Changed 12 months ago by Stuart Auchterlonie

Milestone: unknown30.0
Owner: changed from JYA to Peter Bennett
Status: newassigned

Changed 12 months ago by Peter Bennett

Fix backported from master

comment:2 Changed 12 months ago by Peter Bennett

Status: assignedaccepted

This has already been fixed in MythTV master branch, in a different way. Attached patch (20180509_1445_configure_v29_freetype.patch​) backports the fix to V29. Please revert your patch, test this new patch and let us know if it works.

comment:3 Changed 12 months ago by Peter Bennett

Milestone: 30.029.2

comment:4 Changed 12 months ago by Taijian

OK, I tried out your patch, but it failed to compile, because you missed something.

Add the following to your patch, and you're golden.

@@ -8571,8 +8536,8 @@
 fi
 
 if enabled freetype2; then
-    echo "FREETYPE_CFLAGS=`freetype-config --cflags`" >> $TMPMAK
-    echo "FREETYPE_LIBS=`freetype-config --libs`" >> $TMPMAK
+    echo "FREETYPE_CFLAGS=$($pkg_config --cflags $pkg_config_flags freetype2)" >> $TMPMAK
+    echo "FREETYPE_LIBS=$($pkg_config --libs $pkg_config_flags freetype2)" >> $TMPMAK
 fi
 
 if test $target_os = darwin; then

EDIT: Forgot to account for changed line numbers...

Last edited 12 months ago by Taijian (previous) (diff)

Changed 12 months ago by Peter Bennett

Amended patch with additional fix for freetype-config

comment:5 Changed 12 months ago by Peter Bennett

Thank you for finding that. Revised patch is attached. That fix was also not in master, so I will apply it there as well.

comment:6 Changed 12 months ago by Taijian

You're welcome, and thank you and all the others for working on mythtv!

comment:7 Changed 12 months ago by Peter Bennett <pbennett@…>

Resolution: fixed
Status: acceptedclosed

In 8cbb51a82/mythtv:

configure: new version of freetype2 does not support freetype-config

freetype2 v2.9.1 uses only pkgconfig and removes support for freetype-config

Fixes #13262

comment:8 Changed 12 months ago by Peter Bennett <pbennett@…>

In 5f20e4f3f7/mythtv:

configure: new version of freetype2 does not support freetype-config

freetype2 v2.9.1 uses only pkgconfig and removes support for freetype-config

Fixes #13262

comment:9 Changed 9 months ago by Peter Bennett <pbennett@…>

In 5f20e4f3f7/mythtv:

configure: new version of freetype2 does not support freetype-config

freetype2 v2.9.1 uses only pkgconfig and removes support for freetype-config

Fixes #13262

comment:10 Changed 9 months ago by Peter Bennett <pbennett@…>

In 8cbb51a82/mythtv:

configure: new version of freetype2 does not support freetype-config

freetype2 v2.9.1 uses only pkgconfig and removes support for freetype-config

Fixes #13262

Note: See TracTickets for help on using tickets.