Python Bindings enhancemts according to latest MythTV protocol (91)

[rcrdnalor]

Mythtv v29: Python Bindings enhancements according to latest MythTV protocol:

1) Allow db.seacrchRecorded method to search by given recordedid:

Patch: 0001-Add-recordedid-to-db.seacrchRecorded-method.patch

This patch implements a search inside the recorded table by given recordedid by modifing the already implemented searchRecorded method.

2) Add the recordedfile table to python bindings and make use of it:

Patch: 0002-Python-Bindings-Add-recordedfile-table-and-its-usage.patch

This patch adds the recordedfile table to the python bindings and allows the Recorded instance to use (and update) it.

These patches are compatible with current master and fixes/v29. Once accepted, please backport to fixes/v29.

Example usage:

$ python2
Python 2.7.15rc1 (default, Apr 15 2018, 21:51:34) 
[GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from MythTV import MythDB, MythError, MythDBError, Recorded, RecordedFile
>>> db = MythDB()
>>> reciter = db.searchRecorded(recordedid = 44)
>>> rec = reciter.next()
>>> rec
b'<Recorded 'Servatius Wetter','2018-06-30 11:10:00+02:00' at 0x7efe3fc482a0>'
>>> recfile = rec.getRecordedFile()
>>> recfile
b'<RecordedFile '2105_20180630091000.ts','44' at 0x7efe3fc554f0>'
>>> recfile.keys()
[u'basename', u'filesize', u'width', u'height', u'fps', u'aspect', u'audio_sample_rate', u'audio_channels', u'audio_codec', u'video_codec', u'comment', u'hostname', u'storagegroup', u'id', u'recordedid', u'container', u'total_bitrate', u'video_avg_bitrate', u'video_max_bitrate', u'audio_avg_bitrate', u'audio_max_bitrate']
>>> recfile.values()
[u'2105_20180630091000.ts', 563401220L, 1920, 1088, 25.0, 1.777778, 0, 0, u'AC3', u'H264', u'', u'bionic', u'Default', 51L, 44L, u'MPEG2-TS', 0, 0, 0, 0, 0]

[rcrdnalor]

Add recordedid to Python Bindings

[rcrdnalor]

Add recordedfile to Python Bindings

[ijc]

FWIW (I'm not a maintainer) these like sane to me.

Was the omission of basename and id from the RecordedId._defaults table deliberate?

[rcrdnalor]

@ijc Thank you for reviewing my patches.

I am not sure if I understood your question correctly. If you meant theRecordedfile._defaults object, then the answer is yes. If you look into the mysql description of the recordedfile table (mysql describe recrodedfile), the fields id and basename are key-fields: id is autoincrement, it will be handled by mysql itself, and basename has a key as well, that means, the user needs to provide a valid value. Therefore, no default values are foreseen for those fields.

Could you please review #13299 as well? This is a tricky one and hard to decribe.

Thx, dnalor

[ijc]

Thanks for the explanation, I did mean Recordedfile._defaults and had missed that basename was also a key field.

Will see if I can understand #13299 next...

[Bill Meek]

Roland, are any changes required for Python 3? E.g. in the 2nd patch here: 'comment':u'', 'hostname':'', 'storagegroup':''

[rcrdnalor]

I will add testcases to my repo and include the patches in pull request 182 as a single commit.

This means, one can easily revert it, if necessary.

[rcrdnalor]

With the last change on pull request 182, the search with given 'recordedid' in 'searchRecorded' and the access to the 'recordedFile' table works for python3 as well as for python2

$ python
Python 3.6.8 (default, Aug 20 2019, 17:12:48)
>>> from MythTV import MythDB
>>> db = MythDB()
>>> reciter = db.searchRecorded(recordedid = 4762)
>>> rec = next(reciter)
>>> rec
<Recorded 'The Lady from Shanghai','2019-03-05 13:51:00+01:00' at ..>
>>> recfile = rec.getRecordedFile()
>>> recfile
<RecordedFile '3030_20190305125100.mkv','4762' at 0x7fb32d108ca8>
>>> recfile.items()
[('basename', '3030_20190305125100.mkv'), ('filesize', 2793354377),
('width', 992), ('height', 720), ('fps', 25.0), ('aspect', 1.377778),
 ........   )]
>>> exit()

Please give it a try.

[Roland Ernst <rcrernst@…>]

In c53c444022/mythtv:

Allow 'db.seacrchRecorded' method to search by given 'recordedid'

This patch implements a search inside the 'recorded' table by given
'recordedid' by modifing the already implemented 'searchRecorded' method.

Usage:

$ python

from MythTV import MythDB
db = MythDB()
reciter = db.searchRecorded(recordedid = 4762)
rec = next(reciter)
rec

<Recorded 'The Lady from Shanghai','2019-03-05 13:51:00+01:00' at .>

exit()

refs #13300

[Roland Ernst <rcrernst@…>]

In 871accb425/mythtv:

Add the 'recordedfile' table to python bindings and make use of it

This change adds the 'recordedfile' table to the python bindings and
allows the 'Recorded' instance to use (and update) it.

Usage:

$ python

from MythTV import MythDB
db = MythDB()
reciter = db.searchRecorded(recordedid = 4762)
rec = next(reciter)
rec

<Recorded 'The Lady from Shanghai','2019-03-05 13:51:00+01:00' at ..>

recfile = rec.getRecordedFile()
recfile

<RecordedFile? '3030_20190305125100.mkv','4762' at 0x7fb32d108ca8>

recfile.items()

[('basename', '3030_20190305125100.mkv'), ('filesize', 2793354377),
('width', 992), ('height', 720), ('fps', 25.0), ('aspect', 1.377778),

........ )]

exit()

refs #13300

[Bill Meek]

Closed by #13475