Opened 10 months ago

Closed 9 months ago

#13396 closed Patch - Bug Fix (fixed)

DVB channelscan Scan Progress more than 100%

Reported by: Klaas de Waal Owned by: Klaas de Waal
Priority: minor Milestone: 31.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords: DVB channelscan
Cc: Stuart Auchterlonie Ticket locked: no

Description

In mythtv-setup SCANNING page the progress is presented in the "Scan Progress" status bar. However, the percentage progress that is displayed can be more than 100%. Attached is a screenshot that shows a "Scan Progress" of 117%.

The cause of this is an incomplete initialization, "table scanner reset", in ChannelScanSM::ScanTransport?, file channelscan_sm.cpp. Initialization of the ATSC major and minor numbers is done with SetChannel?(); what needs to be added is a call to SetDVBService() to initialize the network ID and the transport ID.
This is needed for DTVSignalMonitor::HandleSDT().

Below is the code with the fix included:

    // If we have a DTV Signal Monitor, perform table scanner reset
    if (GetDTVSignalMonitor() && GetDTVSignalMonitor()->GetScanStreamData())
    {
        GetDTVSignalMonitor()->GetScanStreamData()->Reset();
        GetDTVSignalMonitor()->SetChannel(-1,-1);
        GetDTVSignalMonitor()->SetDVBService(0, 0, -1);
    }

The patch for this is attached.

Attachments (2)

mythtv-setup_scanning_mma_117.PNG (237.2 KB) - added by Klaas de Waal 10 months ago.
Scan Progress 117% when scanning the last transport.
20190204-scanner-reset.patch (607 bytes) - added by Klaas de Waal 10 months ago.

Download all attachments as: .zip

Change History (4)

Changed 10 months ago by Klaas de Waal

Scan Progress 117% when scanning the last transport.

Changed 10 months ago by Klaas de Waal

comment:1 Changed 9 months ago by Klaas de Waal

Milestone: needs_triage31.0
Owner: set to Klaas de Waal
Status: newaccepted

comment:2 Changed 9 months ago by Klaas de Waal <kdewaal@…>

Resolution: fixed
Status: acceptedclosed

In 8645cb8f1/mythtv:

Perform a DVB table scanner reset after each scanned transport.
This fixes the problem that the received data from a single transport
is processed twice, leading to incorrect timeout messages and also
to a Scan Progress, in the mythtv-setup SCANNING page, of more than 100%

Fixes #13396

Signed-off-by: Klaas de Waal <kdewaal@…>

Note: See TracTickets for help on using tickets.