Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#13439 closed Patch - Bug Fix (fixed)

Invalid timeout in MythSocket::Announce

Reported by: David Hampton Owned by: David Hampton
Priority: minor Milestone: 30.1
Component: MythTV - General Version: v30-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The socket code was reworked in 2009 in commit 2285786158, and the second argument to ReadStringList? was changed from 'bool quickTimeout' to 'uint timeoutMS'. Fix one call to ReadStringList? that didn't get converted back then. This appears to only be used by the mediaserver code, which might explain why it has gone unnoticed.

Change History (2)

comment:1 Changed 8 months ago by David Hampton <mythtv@…>

Resolution: fixed
Status: assignedclosed

In 00f0e42963/mythtv:

Fix timeout on mediaserver announcements.

The socket code was converted in 2009 from taking a boolean to indicate
a 'short' timeout, to taking an actual timeout in milliseconds. Fix
one location that didn't get converted.

Fixes #13439.

comment:2 Changed 8 months ago by David Hampton <mythtv@…>

In 8e50fcf60/mythtv:

Fix timeout on mediaserver announcements.

The socket code was converted in 2009 from taking a boolean to indicate
a 'short' timeout, to taking an actual timeout in milliseconds. Fix
one location that didn't get converted.

Fixes #13439.

(cherry picked from commit 66d8960da3e47023344a4caa1edaa37eff6f64b8)

Note: See TracTickets for help on using tickets.