Opened 6 years ago

Closed 5 years ago

#13488 closed Patch - Bug Fix (Fixed)

IPTV fix for deadlock, handle redirects

Reported by: ijc Owned by: paul-h
Priority: minor Milestone: 31.0
Component: MythTV - HTTP Streaming Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I posted various IPTV fixes at ​https://github.com/MythTV/mythtv/pull/184. There's a long description over there which I won't repeat unless requested. Briefly, fixes:

  • A deadlock in HLSReader cancel path
  • Not handling m3u8 which has a 302 redirect
  • A segfault when combining overlapping segments which have gone backwards
  • Avoid hitting the servers for every single channel, we don't need precise protocol information at that time.
  • A few other random typos, log improvements, setting a User-Agent header.

Attachments (1)

iptv-20190928.tar​ (50.0 KB) - added by ijc 6 years ago.
patches corresponding to ​https://github.com/MythTV/mythtv/pull/184/commits/01099ce4decba9c624121212a49bee72cd26e283

Download all attachments as: .zip

Change History (16)

Changed 6 years ago by ijc

Attachment: iptv-20190928.tar​ added

patches corresponding to ​https://github.com/MythTV/mythtv/pull/184/commits/01099ce4decba9c624121212a49bee72cd26e283

comment:1 Changed 6 years ago by paul-h

Milestone: needs_triage → 31.0
Owner: changed from cpinkham to paul-h
Status: new → accepted

I've been sitting on a related patch to save the protocol in the database so we don't have to keep doing test downloads to determine if the IPTV channel is a playlist file or TS stream. This is particularly a problem that affects the VBOX. I'll try to combine both sets of patches.

comment:2 Changed 6 years ago by ijc

Please see ​https://code.mythtv.org/trac/ticket/13489 for an incremental fix to the unit tests.

comment:3 Changed 6 years ago by Ian Campbell <ijc@…>

In 2cf309cd0/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:4 Changed 6 years ago by Ian Campbell <ijc@…>

In 2d9065e8c/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:5 Changed 6 years ago by Ian Campbell <ijc@…>

In 3d48c63a7/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:6 Changed 6 years ago by Ian Campbell <ijc@…>

In 163e1a4a4f/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:7 Changed 6 years ago by Ian Campbell <ijc@…>

In 783e0dfd6/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:8 Changed 6 years ago by Ian Campbell <ijc@…>

In 13976eae2/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:9 Changed 6 years ago by Ian Campbell <ijc@…>

In 7d1c0d1eb1/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:10 Changed 6 years ago by Ian Campbell <ijc@…>

In 2b6381407/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:11 Changed 6 years ago by Ian Campbell <ijc@…>

In 10691b473/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:12 Changed 6 years ago by Ian Campbell <ijc@…>

In 3e61fef82/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:13 Changed 6 years ago by Ian Campbell <ijc@…>

In a2ac6aa62/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:14 Changed 6 years ago by Ian Campbell <ijc@…>

In 36d96c956/mythtv:

Error: Processor CommitTicketReference failed
GIT backend not available

comment:15 Changed 5 years ago by paul-h

Resolution: → Fixed
Status: accepted → closed
Note: See TracTickets for help on using tickets.