Opened 3 months ago

Closed 3 months ago

#13526 closed Patch - Feature (Fixed)

Feature patch - Ansible cleanup of (now) unused legacy lame variables

Reported by: Gary Buhrmaster Owned by: Stuart Auchterlonie
Priority: minor Milestone: 31.0
Component: Ansible Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Feature patch - Ansible cleanup of unused legacy lame variables

In 63b454726bf6d4d260d3757ed6c0acb1c4604e5a lame builds were removed from the rpm/dnf tasks,but the variables used for those tasks remained.

Remove the (now) unused variables.

Proposed patch:

diff --git a/roles/mythtv-dnf/vars/main.yml b/roles/mythtv-dnf/vars/main.yml
index e025e15..61f3ab6 100644
--- a/roles/mythtv-dnf/vars/main.yml
+++ b/roles/mythtv-dnf/vars/main.yml
@@ -6,6 +6,3 @@ rpmfusion_rpm: "http://download1.rpmfusion.org/free/fedora/rpmfusion-free-releas
 rpmfusion_rawhide_rpm: "http://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-rawhide.noarch.rpm"
 rpmfusion_el_rpm: "https://download1.rpmfusion.org/free/el/rpmfusion-free-release-{{ ansible_distribution_major_version }}.noarch.rpm"
 
-lame_src: " http://download1.rpmfusion.org/free/el/updates/6/SRPMS/lame-3.99.5-1.el6.src.rpm"
-lame_rpm: "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm" 
-lame_rpms_all: "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-libs-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-devel-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm"
diff --git a/roles/mythtv-rpm/vars/main.yml b/roles/mythtv-rpm/vars/main.yml
index c8fc772..4f863f6 100644
--- a/roles/mythtv-rpm/vars/main.yml
+++ b/roles/mythtv-rpm/vars/main.yml
@@ -4,6 +4,3 @@ epel_rpm: "https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rp
 
 rpmfusion_rpm: "http://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-{{ ansible_distribution_major_version }}.noarch.rpm"
 
-lame_src: " http://download1.rpmfusion.org/free/el/updates/6/SRPMS/lame-3.99.5-1.el6.src.rpm"
-lame_rpm: "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm" 
-lame_rpms_all: "~/rpmbuild/RPMS/{{ansible_architecture}}/lame-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-libs-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm ~/rpmbuild/RPMS/{{ansible_architecture}}/lame-devel-3.99.5-1.el7.centos.{{ansible_architecture}}.rpm"

Change History (4)

comment:1 Changed 3 months ago by Stuart Auchterlonie

Milestone: needs_triage31.0
Status: newaccepted

Gary,

lame does not appear to have been removed in any committed changeset. Is this something you have locally?

Regards Stuart

comment:2 Changed 3 months ago by Stuart Auchterlonie

Status: acceptedinfoneeded

comment:3 Changed 3 months ago by Gary Buhrmaster

The rpmfusion download and builds for lam was removed in 63b454726bf6d4d260d3757ed6c0acb1c4604e5a (which the lame_src ... variables were used for), as lame is now in fedora/epel. So this was just intended as follow-on cleanup for now unused variables.

comment:4 Changed 3 months ago by Stuart Auchterlonie

Resolution: Fixed
Status: infoneededclosed
Note: See TracTickets for help on using tickets.