Opened 8 months ago

Closed 8 months ago

#13542 closed Patch - Feature (fixed)

Feature patch - qmake .pro file modernization for various non-app directories

Reported by: Gary Buhrmaster Owned by: David Hampton
Priority: minor Milestone: 31.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Feature patch - qmake .pro file modernization for various non-app directories

Change qmake TEMPLATE to aux (from app) for directories that do not build anything (and remove app template artifacts).

The aux template was added in QT5.  Per the docs the aux template "Creates a Makefile for not building anything. Use this if no compiler needs to be invoked to create the target" which is exactly what we want for these directories.

The patch was mostly mechanical (update the .pro file, remove the dummy.c source file).

*SPECIAL NOTE* These updates should arguably also update the .gitignore files in the respective directories to no longer exclude the target binary (created from dummy.c), but to remove that target binary would require every developer to run a make clean/distclean before pulling the commit to avoid the possibility of accidentally adding that (now leftover) binary into the project at some future commit.  As the cost of the .gitignore entry is small, I made the choice to not update .gitignore in the directories.  If the committer is confident that there will be no confusion, removing (or emptying the contents of) the .gitignore from the impacted directories can be performed.  Caveat Emptor.

Patch attached.

Attachments (1)

mythtv-template-modernization.patch (10.5 KB) - added by Gary Buhrmaster 8 months ago.
qmake .pro file modernization

Download all attachments as: .zip

Change History (3)

Changed 8 months ago by Gary Buhrmaster

qmake .pro file modernization

comment:1 Changed 8 months ago by David Hampton

Milestone: needs_triage31.0
Owner: set to David Hampton
Status: newassigned

comment:2 Changed 8 months ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: assignedclosed

In c62efb3fe7/mythtv:

Update qmake .pro file modernization for various non-app directories

Change qmake TEMPLATE to aux (from app) for directories that do not
build anything (and remove app template artifacts).

The aux template was added in QT5. Per the docs the aux template
"Creates a Makefile for not building anything. Use this if no compiler
needs to be invoked to create the target" which is exactly what we
want for these directories.

Fixes #13542.

Signed-off-by: David Hampton <mythtv@…>

Note: See TracTickets for help on using tickets.