Bugs in backend serviceAPIs

[Peter Bennett]

The leanfront frontend for MythTV uses service APIs exclusively to support a fully functional frontend. In the process of developing this I have found some bugs in the service APIs:

• File names in URLS should be url encoded (art urls). The way they currently are returned, the URL fails if a program title has a colon or other special character (e.g. Law and Order: Special Victim's Unit).
• Redirect for download of files on slave backends use wrong URL. Redirects to host name as server address. This does not work if there is no DNS or the DNS name does not match the MythTV host name. The API should look up the IP address of the host in the settings and use that. (Note I cannot use the hosts file to resolve the address since the APIs are called from Android and you cannot update android system files).
• Settings API returns nothing for null host id requests. Entries that are system wide have null host id and they should be able to be read.
• GetRecordedList has parameters for selecting by RecordId, Start Time and many others. It seems that whatever you specify, you still get the full unfiltered list
• Guide/GetProgramGuide has a problem if two channels have the same xmltvid. It only gets the programs on one of the channels and the other channel is omitted. This can happen for various reasons, e.g. the same channel is available on two frequencies. Mythfrontend does not have this problem, and Guide/GetProgramList does not have this problem.

[Bill Meek]

The answer to the last bullet is HostName?=_GLOBAL_ . I recall that the thinking was that a hostname could be "NULL".

Ref: deceaa46293510164e8d63da1c4be6c3e8149800

[Peter Bennett]

Replying to Bill Meek:

The answer to the last bullet is HostName?=_GLOBAL_ . I recall that the thinking was that a hostname could be "NULL".

Ref: deceaa46293510164e8d63da1c4be6c3e8149800

Thank you, I will try that.

[Peter Bennett]

Upon retesting, GetRecordedList filters are working correctly, and there is no filter for recordedid.

[Peter Bennett]

The last bug listed, Guide/GetProgramGuide, uses "Group By CallSign", with the result that if two or more channels have the same call sign, only one of them is included in the list. With Comcast, the same station is broadcast on several channels, and if you have your channels set up like that you likely want to see the listings the same way. I am changing this to no longer group that way.

[Peter Bennett]

I will leave the Guide/GetProgramGuide? as it is, because if you have multiple input connections (e.g. cable and broadcast), you don't want the same stations repeated in your list.

[Peter Bennett]

Fixed all except last one in 0b155ab089cce1137af0acb7f7a6f0f7af2b7867

Last issue reopened in ​https://github.com/MythTV/mythtv/issues/243