Opened 14 years ago

Closed 14 years ago

#1559 closed defect (fixed)

Endian fix in r9398 of audiooutputca.cpp breaks sound on PPC architectures

Reported by: mcdermj@… Owned by: Nigel
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The fix applied for OSX on Intel in audiooutputca.cpp causes audio on PPC platforms to be garbled. The fix uses the WORDS_BIGENDIAN #define, but does not include config.h where it lives, and therefore always compiles for little endian architectures. I am attaching a patch, but I'm not sure where the preferred place to pull in config.h, or whether there's a better way of doing it.

Attachments (1)

audiooutputca.cpp.patch (332 bytes) - added by mcdermj@… 14 years ago.
Simple addition of config.h

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by mcdermj@…

Attachment: audiooutputca.cpp.patch added

Simple addition of config.h

comment:1 Changed 14 years ago by Nigel

Status: newassigned

Oops. Thanks for finding that, Jeremy.
Pulling in either of config.h or mythconfig.h is the correct fix.

comment:2 Changed 14 years ago by Nigel

Resolution: fixed
Status: assignedclosed

(In [9438]) In fixing Intel audio, I broke PPC. Sigh. Closes #1559

comment:3 Changed 14 years ago by cnh_pub@…

Resolution: fixed
Status: closedreopened

This is also still broken on the 0.19-fixes branch.

comment:4 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: reopenedclosed

Not everything goes into the fixes branch.

Note: See TracTickets for help on using tickets.