Opened 18 years ago
Closed 18 years ago
#1559 closed defect (fixed)
Endian fix in r9398 of audiooutputca.cpp breaks sound on PPC architectures
Reported by: | Owned by: | Nigel | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
The fix applied for OSX on Intel in audiooutputca.cpp causes audio on PPC platforms to be garbled. The fix uses the WORDS_BIGENDIAN #define, but does not include config.h where it lives, and therefore always compiles for little endian architectures. I am attaching a patch, but I'm not sure where the preferred place to pull in config.h, or whether there's a better way of doing it.
Attachments (1)
Change History (5)
Changed 18 years ago by
Attachment: | audiooutputca.cpp.patch added |
---|
comment:1 Changed 18 years ago by
Status: | new → assigned |
---|
Oops. Thanks for finding that, Jeremy.
Pulling in either of config.h or mythconfig.h is the correct fix.
comment:2 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:3 Changed 18 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This is also still broken on the 0.19-fixes branch.
comment:4 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Not everything goes into the fixes branch.
Note: See
TracTickets for help on using
tickets.
Simple addition of config.h