Opened 13 years ago

Closed 13 years ago

#1569 closed patch (fixed)

mythvideo grab-bag 'o crunchy goodness

Reported by: gnassas@… Owned by: Anduin Withers
Priority: minor Milestone: 0.20
Component: mythvideo Version: 0.19
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I have over 1,000 files in mythvideo which is a lot for my puny epia and xbox machines so I decided do do something about speeding up the load time. Once I started hacking I got carried away...

this patch contains the following fixes

1: lazy loading for Genres and Countries

cuts my gallery entry time by half when filebrowsing is active and even more when I'm pulling the list of videos from the database

2: folder display for non-browsing gallery view

it looks like the original author intended this but never got it working. Also, in the menu popup, I added a flat view option but it's not persistent. Should it be? Personally, I hate flatview

3: ability to order videos by videometadata.intid

essentially your most recently added videos bubble up to the top of the list. Handy for when you have > 1,000 videos and you want to edit the metadata of your newest dvd rips without hunting through the whole collection

this obviates the need for #679 which is hereby withdrawn

4: option to sort folders before or within videos

somebody asked for this on -users and it was easy to do

5: allow multiple videos to have the same title

not an issue for me but recently somebody on -users or -dev mentioned how two videos with the same name will stomp over each other during sorting and I happened to be in the neighbourhood so...

6: VideoList::addFileNode

couldn't readily see wtf it was doing so it got a friendly rewrite

7: handle uft8 characters in file and directory names

filenames with non-latin characters were getting into the database uninterpreted. This caused videomanager to prattle on about "file ZZZ is missing, remove it?" even though the video wasn't really missing

btw, mythgallery appears to have a similar issue

I'm working from a revision just before the .19 release so this patch might apply cleanly to -fixes for the cautious souls among us

Attachments (2)

grabbag.diff.gz (3.4 KB) - added by gnassas@… 13 years ago.
the crunchy patch
grabbag-2.diff.gz (3.4 KB) - added by gnassas@… 13 years ago.
a crunchier patch

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by gnassas@…

Attachment: grabbag.diff.gz added

the crunchy patch

comment:1 Changed 13 years ago by gnassas@…

There was a comment about the unnecessary scan of the QMap in VideoList::buildDbList so I updated it to use the tactic from #1354 with the difference that the filepath is appended to keep the sort order predictable. Updated patch to follow.

Changed 13 years ago by gnassas@…

Attachment: grabbag-2.diff.gz added

a crunchier patch

comment:2 Changed 13 years ago by michael.knoll@…

Patch applied to my 0.19 MythVideo? setup. The patch made a dramatic difference in my large(1000+ videos) library. The load times went from minutes to seconds. Highly recommend commiting this to the distro.

comment:3 Changed 13 years ago by jason.fisher@…

Is this in SVN now, or do I still need to apply it manually?

comment:4 Changed 13 years ago by gnassas@…

You still need to apply this manually.

comment:5 Changed 13 years ago by Anduin Withers

Owner: changed from Isaac Richards to Anduin Withers

comment:6 Changed 13 years ago by Anduin Withers

Resolution: fixed
Status: newclosed

(In [10852]) Closes #2197, #1647, #1746, #679, #1569, #1678, #2040, #2159, #2167, #2170

Various small cleanups and speed improvements.

  • Folders in metadata only view
  • Option to ignore case in title comparisons (though a locale may override this)
  • Multiple prefixes should be consistent now
  • All metadata fields are available to the theme in all views
  • Minor redraw issue
  • Consistent metadata representation across views (where appropriate)

Fixes fully (to my knowledge) all referenced tickets.

Note: See TracTickets for help on using tickets.