Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 8 years ago

Closed 6 years ago

#1810 closed patch (wontfix)

Improvements for Mythgame....

Reported by: jochen Owned by: greg
Priority: minor Milestone: 0.21
Component: mythgame Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

A few Improvements for Mythgame:

  • The loading of a Romimage is now delayed by a qtimer. SO The scrolling throug your romdatabase goes verry fast, also if you have Screenshots for your roms.
  • Include of Screenshot generation directly into mythgame. Now the functionality of generating screenshots for your roms (with the script of ticket 225) is now directly included to mythgame.

Attachments (5)

game.patch (16.2 KB) - added by jochen 8 years ago.
first Version…
game2.patch (16.4 KB) - added by jochen 8 years ago.
Version 2
game3.patch (14.8 KB) - added by babysimon 8 years ago.
Patch that works for me
gamePatch4.patch (18.3 KB) - added by ryebrye@… 7 years ago.
gamePatch4.patch
gamePatch4s.patch (66.6 KB) - added by ryebrye@… 7 years ago.
Same as above patch - but this one uses spaces instead of tabs for all the files. It's much bigger because mythgame had lots of tabs in the code prior to this patch.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 8 years ago by greg

Did you mean to attach a patch to this?

Changed 8 years ago by jochen

first Version...

comment:2 Changed 8 years ago by jochen

Sorry, I was too fast to write this text...

Here is now a first Version of the patch, delay works, but screenshot generation is not really tested (progred this at work today)

Changed 8 years ago by jochen

Version 2

comment:3 Changed 8 years ago by jochen

  • Component changed from mythtv to mythgame

Now Spaces in Rom Names are supported (when the romname is within "").

I have looked, the parameters are correctly passed to the emu, but zsens nevertheless works, doesn't know why...

comment:4 Changed 8 years ago by jochen

could please somone else test if my screenshot patch is working... i have problems with my x drivers so the emus don't work correctly on my system...

comment:5 Changed 8 years ago by jochen

The delay patch is now already in svn. So that my system works again, i will test the other part (screenshot generation) and hopefully it get also into svn.

comment:6 Changed 8 years ago by greg

  • Milestone changed from 0.20 to 0.21

comment:7 Changed 8 years ago by babysimon

I've fixed some problems with the previous patch (that stopped it working altogether for me). The old patch built up a command line then split it into arguments for QProcess in a way which looked fragile. As a by-product it passed arguments to QProcess still with quotes round them. The new version just tells QProcess to execute "sh -c". Hopefully this is acceptable.

Criticism gratefully received from anyone who knows C++ from their elbow, but at least this works for me now.

Changed 8 years ago by babysimon

Patch that works for me

Changed 7 years ago by ryebrye@…

gamePatch4.patch

comment:8 Changed 7 years ago by ryebrye@…

In gamePatch4.patch I updated a few things:

The previous patch would go crazy if an emulator (i.e. sdlmess when it's passed a bad argument) exited prior to the timer for the screenshot expiring- causing the timer to kill whatever process was running at that time and screwing up the naming of the screenshots. I fixed it so now no matter what it will wait the length of the screenshot timeout and stay on track. When the timer comes up, if the process is no longer running it will not take a screenshot.

(A future add-on would be to flag these roms that exited unexpectedly and have the option to purge them from the DB - thus making generate screenshots also function as a "scrub my roms list of bogus roms" feature)

I also added in a progress bar to track screenshot generation progress.

When you tell it to generate screenshots, I also added in a yes/no dialog to ask the user if they would like to overwrite existing screenshots. If they say "no" it will check for existing ones before taking a new one, and skip it if one already exists. If they say "yes" it will not bother to check for existing ones, and just keep plugging along.

Let me know what it would take to get this into the trunk, and I'll work on it... because imho MythGame? really is worthless as a frontend for emulators if it has no screenshot previews - and generating them manually is a royal pain in the rear.

Changed 7 years ago by ryebrye@…

Same as above patch - but this one uses spaces instead of tabs for all the files. It's much bigger because mythgame had lots of tabs in the code prior to this patch.

comment:9 follow-up: Changed 7 years ago by jochen

maybe we should set the screenshot time for each emulator individual??

comment:10 in reply to: ↑ 9 Changed 6 years ago by greg

  • Resolution set to wontfix
  • Status changed from new to closed

I'm closing this.

I will accept a external screenshot generator, but not I ran into too many lockups with using the various internal grabber attempts.

If someone has or wants to submit an external grabber that just pulls the needed info from the database I'd certainly look at adding that.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.