Opened 13 years ago

Closed 12 years ago

Last modified 9 years ago

#1848 closed patch (fixed)

mythfilldatabase gives too much meaning to TMSDataDirect fccChannelNumber

Reported by: Anduin Withers Owned by: danielk
Priority: blocker Milestone: 0.20
Component: mythtv Version: head
Severity: high Keywords:
Cc: Ticket locked: no

Description

The fccChannelNumber is incorrectly being used as the frequency id whenever it is found in the station definition. For non-OTA this is bad (you end up with cable channel X being mapped to frequency id Y, when you wanted X=X).

The attached patch only honors the fccChannelNumber as the frequency id if the lineup type is LocalBroadcast?.

Attachments (1)

mfdb_chanid_fix2.patch (5.1 KB) - added by Anduin Withers 12 years ago.

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by Anduin Withers

Attachment: mfdb_chanid_fix2.patch added

comment:1 Changed 12 years ago by Anduin Withers

Owner: changed from Anduin Withers to danielk

Reassigned so Daniel can apply it after #1966 goes in.

comment:2 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [10393]) Closes #1848. Only sets freqid in process_dd_station if the listings have the "LocalBroadcast?" type, other TMS listing channel numbers are too unreliable.

comment:3 Changed 12 years ago by Isaac Richards

Resolution: fixed
Status: closedreopened

Not fixed.

comment:4 Changed 12 years ago by Isaac Richards

Priority: minorcritical
Severity: mediumhigh

Upping priority due to causing completely incorrect tuning.

comment:5 Changed 12 years ago by Isaac Richards

Milestone: 0.20
Version: head

comment:6 Changed 12 years ago by Anduin Withers

Owner: changed from danielk to Anduin Withers
Status: reopenednew

comment:7 Changed 12 years ago by danielk

(In [10516]) Refs #1848. Temporary hack to allow tuning when freqid is missing, while underlying problem is fixed.

comment:8 Changed 12 years ago by Anduin Withers

Resolution: fixed
Status: newclosed

(In [10517]) Closes #1848

Sets freqid = channum if it didn't get set (fixes freqid=0). Stops disappearing real channels that are unfortunate enough to have the same channum as an ATSC major+minor number.

comment:9 Changed 12 years ago by danielk

Priority: criticalmajor
Resolution: fixed
Status: closedreopened

This doesn't yet fix channels inserted with the broken code. See my e-mail.. (Basically, if the mplexid is not valid set freqid and a mplexid of "" should be considered an unset mplexid).

Lowering to "major" since tuning portion is fixed.

comment:10 Changed 12 years ago by danielk

Owner: changed from Anduin Withers to danielk
Priority: majorblocker
Status: reopenednew

Fixes for analog have broken initial setup for digital..

I'll try to get this right for both this week.

comment:11 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [10612]) Fixes #1848. Refs #2053. Allows DTV cards to be hooked up to DataDirect? without manual editing again.

There is still some work to do to prevent mythfilldatabase from mucking with the datadirect lineups when it doesn't need to so I'm keeping #2053 open.

The only time you really need to touch the datadirect lineups are:

  • right after a digital channel scan to get the xmltvid matches
  • when datadirect tries to add channels to a digital source (so you don't download listings data for an untunable channel).
  • when the user explicitly asks you do so to with --remove-new-channels and there are actually new channels to remove.
  • when you start up the frontend channel editor, and sometime after you leave it if xmltvid changes are made.

The code is still touching the lineups twice every time mythfilldatabase is run for digital sources, even when every channel has an xmltvid, and after any time you run the frontend channel editor (whether changes were made or not).

Note: See TracTickets for help on using tickets.