Opened 13 years ago

Closed 13 years ago

#1894 closed patch (fixed)

Various cosmetic bug-fixes/improvements to program guides

Reported by: mythtv@… Owned by: Isaac Richards
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords: MythCentre Program Guide
Cc: Ticket locked: no

Description

I have some channel icons that contain transparency information. The code that displays the channel’s call sign underneath the channel icon was causing me some problems because the text was visible through the transparent icons. The attached “guideicons.patch” file tweaks this code so that the text is only displayed if there is no channel icon configured for a given channel. It also contains a minor optimisation so that if the channel icon contained within the database cannot be located on the disk the cached icon filename is reset so that the guide doesn’t keep trying to load the same icon each time the channel is visited in the guide. I found that this greatly improved the scrolling performance when icons are missing for one reason or another.

Whilst I was looking into these problems, I noticed that the large (current) channel icon had a black background behind it, yet the smaller (per-channel) icons displayed in the main guide list did not. I discovered this black background came from the theme background images. I personally think that it looks better without this black background so I have produced some modified background images with the black square removed. “gg-backgrounds.tgz” (containing updates for both “default” and “default-wide” versions)

I also noticed that the “gg-vid-background” images (used for the program guide whilst watching TV, with the video in the top right-hand corner) differed from the “gg-background” images (used for the main program guide, without the video in the top corner), with respect to the current date being placed in its own box. Again, personally I think it looks better without the box, so I’ve made them both the same.

Along the way, I came across some minor problems with the “MythCenter?” and “MythCenter?-wide” themes. I’m not sure that I can remember all of the tweaks, but they include; video overlay not exactly lining up with background “Loading Preview Video…” box, “Loading Preview Video…” being over-drawn on the video feed whenever the cursor moved in the program guide for the “MythCenter?-wide” theme, channel icons being stretched/distorted, the channel identification area being a different size between the video overlay guide and the normal guide. These changes were all tweaks to the MythCentre? theme XML files and are contained in the attached “MythCenter?.patch” and “MythCentre?-wide.patch” files.

Attachments (6)

guideicons.patch (2.3 KB) - added by mythtv@… 13 years ago.
Missing icon text patch
gg-backgrounds.tgz (33.1 KB) - added by mythtv@… 13 years ago.
Updated background images
MythCenter.patch (4.3 KB) - added by mythtv@… 13 years ago.
MythCenter? XML updates
MythCenter-wide.patch (4.0 KB) - added by mythtv@… 13 years ago.
MythCentre?-wide XML updates
browseicons.patch (1.1 KB) - added by mythtv@… 13 years ago.
patch to resolve incorrect browse mode icon handling
browseicons.2.patch (1.6 KB) - added by mythtv@… 13 years ago.
Updated patch for post r10358

Download all attachments as: .zip

Change History (12)

Changed 13 years ago by mythtv@…

Attachment: guideicons.patch added

Missing icon text patch

Changed 13 years ago by mythtv@…

Attachment: gg-backgrounds.tgz added

Updated background images

Changed 13 years ago by mythtv@…

Attachment: MythCenter.patch added

MythCenter? XML updates

Changed 13 years ago by mythtv@…

Attachment: MythCenter-wide.patch added

MythCentre?-wide XML updates

comment:1 Changed 13 years ago by mythtv@…

In response to a request from Cougar at random dot ee regarding a problem where using the channel browse mode and changing from a channel with a configured channel icon to one without an icon would result in the original channel icon still being displayed, the attached "browseicons.patch" file resolves this problem.

Changed 13 years ago by mythtv@…

Attachment: browseicons.patch added

patch to resolve incorrect browse mode icon handling

comment:2 Changed 13 years ago by danielk

Milestone: 0.20
Owner: changed from Isaac Richards to danielk

comment:3 Changed 13 years ago by Isaac Richards

Owner: changed from danielk to Isaac Richards

Wanted this one..

Changed 13 years ago by mythtv@…

Attachment: browseicons.2.patch added

Updated patch for post r10358

comment:4 Changed 13 years ago by Isaac Richards

(In [11028]) Fix for improperly cached OSD images.

Refs #1894.

comment:5 Changed 13 years ago by Isaac Richards

(In [11029]) Handle translucent/semi-transparent channel icons in the guide better.

Refs #1894.

comment:6 Changed 13 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [11030]) Cosmetic improvements to the program guide. Final part of #1894.

Closes #1894.

Note: See TracTickets for help on using tickets.