Opened 14 years ago

Closed 13 years ago

#1906 closed patch (wontfix)

Patch to add more unit conversion options to MythWeather.

Reported by: mythtv-dev@… Owned by: ldunning
Priority: minor Milestone: unknown
Component: mythweather Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Here's a patch to add two more type of unit conversions to MythWeather?. They are:

  • SI units except distance and speed in miles.
  • SI units except distance and speed in nautical miles.

The patch is against version 0.19 but it applies to SVN head.

It introduces two new values in the settings database for SIUnits, namely YES_MILES and YES_NAUTICAL, the existing values of YES and NO apply to the original two options making this change compatible (i.e. an unpatched MythWeather? just does imperial units if these new values are in the database).

The patch includes changes to the setting UI so that the change can be made from the frontend.

I've tested it as much as possible and it seems to work OK. Hope you like it.

Attachments (1)

weather_units.3.patch (13.9 KB) - added by mythtv-dev@… 14 years ago.
Patch for two new unit conversions in MythWeather?

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by mythtv-dev@…

Attachment: weather_units.3.patch added

Patch for two new unit conversions in MythWeather?

comment:1 Changed 13 years ago by mythtv-dev@…

Assigning to ijr as per the maintainer list, hope that's OK.

comment:2 Changed 13 years ago by Isaac Richards

Owner: changed from Isaac Richards to ldunning

comment:3 Changed 13 years ago by ldunning

Resolution: wontfix
Status: newclosed

The plugin has been too substantially changed for this patch to be applicable. Unfortunately with the new design, it would be difficult to implement this feature. Sorry.

Note: See TracTickets for help on using tickets.