Opened 13 years ago

Closed 13 years ago

#2155 closed patch (fixed)

disable OSD message at stream info change

Reported by: Pekka Jääskeläinen <pekka.jaaskelainen@…> Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The code added for detecting stream info change and enabling subtitles if they are desired and found in the new stream printed to the OSD an annoying "Subtitle X set" message every time the stream meta data changed.

This patch disables the OSD message in the automated subtitle enabling.

Attachments (3)

no_osd_message_at_stream_info_change.diff (3.7 KB) - added by Pekka Jääskeläinen <pekka.jaaskelainen@…> 13 years ago.
Against trunk
no_osd_message_at_stream_info_change.v2.diff (6.9 KB) - added by Pekka Jääskeläinen <pekka.jaaskelainen@…> 13 years ago.
Improved version (the previous didn't take all unnecessary OSD messages such as after seeking etc. out)
no_osd_message_at_stream_info_change.v3.diff (7.0 KB) - added by Pekka Jääskeläinen <pekka.jaaskelainen@…> 13 years ago.
Hides (hopefully) the last message when subtitles are disabled at stream info change

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by Pekka Jääskeläinen <pekka.jaaskelainen@…>

Against trunk

Changed 13 years ago by Pekka Jääskeläinen <pekka.jaaskelainen@…>

Improved version (the previous didn't take all unnecessary OSD messages such as after seeking etc. out)

comment:1 Changed 13 years ago by danielk

Milestone: 0.200.21

comment:2 Changed 13 years ago by danielk

Severity: mediumlow
Version: head

Changed 13 years ago by Pekka Jääskeläinen <pekka.jaaskelainen@…>

Hides (hopefully) the last message when subtitles are disabled at stream info change

comment:3 Changed 13 years ago by stuartm

IMHO this patch looks fine and should probably go in for 0.20. I'm unable to test it on ordinary recordings as subtitle streams don't change here in the same way as they obviously do elsewhere. I've made additions to the original patch so the messages are disabled for DVDs too and have verified this to work.

If Daniel has no objections I'll commit this.

comment:4 Changed 13 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [10856]) Apply patch by Pekka J?\195?\164?\195?\164skel?\195?\164inen to disable the subtitle on/off OSD message when the stream info changes.

Additional to the original patch, the messages are disabled for DVDs too.

Closes #2155

Note: See TracTickets for help on using tickets.