Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2210 closed defect (fixed)

DVB subtitles are not enabled after exiting from the teletext view

Reported by: otto at kolsi dot fi Owned by: stuartm
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

With DVB-T and SVN 10882.

When watching DVB recordings with subtitles enabled, if user enters to the Teletext Menu and then exists from there back to watching the recording, subtitles are no longer enabled. NuppelVideoPlayer? should re-enable subtitles when teletext mode is exited (probably in NuppelVideoPlayer::DisableTeletext?()).

This same behaviour might also occur with other type of subtitles.

Attachments (1)

teletext_subtitle_toggle.diff (1.6 KB) - added by stuartm 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by stuartm

Milestone: 0.20
Owner: changed from Isaac Richards to stuartm
Status: newassigned

Changed 13 years ago by stuartm

comment:2 Changed 13 years ago by stuartm

otto at kolsi dot fi, can you test the attached patch. It's pretty simple and should work but as I can't test it here I just want to be sure.

In particular if you have teletext subtitles in addition to dvb subtitles, could you see if anything breaks when enabling different combinations of those three? I'm might have missed something ...

comment:3 Changed 13 years ago by stuartm

Resolution: fixed
Status: assignedclosed

(In [10887]) Re-enable subtitles or captions after leaving teletext.

Fixes #2210

comment:4 Changed 13 years ago by stuartm

(In [10922]) Include teletext subtitles in the fix for #2210.

Refs #2210

comment:5 Changed 13 years ago by danielk

(In [10931]) Refs #2210. Reordering of [10922] to keep pre-[10887] ordering and to keep logic clear.

Note: See TracTickets for help on using tickets.