Opened 13 years ago

Closed 13 years ago

#2620 closed patch (fixed)

perl bindings - use Config in Recording.pm

Reported by: sphery <mtdean@…> Owned by: xris
Priority: minor Milestone: unknown
Component: perl / nuvexport Version: 0.20
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Recoding.pm uses $Config{'byteorder'} when processing NuppelVideo files; however it does not import Config, so each NuppelVideo file results in:

Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 122.
Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 159.
Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 176.
Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 192.

The attached patch adds a "use Config;" to Recording.pm to allow the byteorder check to succeed. My lack of Perl skills make me wonder if this is indeed the proper fix (and/or proper location for the fix), but if nothing else, identifying the issue should make fixing it easy for a real Perl coder.

Attachments (1)

mythtv-perl_bindings-Recording_use_Config.patch (444 bytes) - added by sphery <mtdean@…> 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by sphery <mtdean@…>

comment:1 Changed 13 years ago by sphery <mtdean@…>

Ooops. Line numbers above are off by 3--I ran the test with the fix commented, rather than on the original version. The file was otherwise unchanged. Below is the older run (on an unmodified Recording.pm) I meant to copy/paste originally:

Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 119.
Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 156.
Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 173.
Use of uninitialized value in numeric eq (==) at /usr/lib/perl5/site_perl/5.8.3/MythTV/Recording.pm line 189.

comment:2 Changed 13 years ago by xris

Component: mythtvperl / nuvexport
Owner: changed from Isaac Richards to xris

comment:3 Changed 13 years ago by xris

Resolution: fixed
Status: newclosed

(In [11707]) Add a 'use Config' to get rid of an error parsing nupplevideo files; closes #2620

Note: See TracTickets for help on using tickets.