Opened 20 years ago
Closed 19 years ago
Last modified 18 years ago
#30 closed patch (fixed)
DVB Subtitles Support
Reported by: | Owned by: | taylor | |
---|---|---|---|
Priority: | minor | Milestone: | 0.19 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
I think the DVB subtitles patch is ready to be merged. Seems not to crash anymore and timing issues are more or less solved.
http://www.cs.tut.fi/~pjaaskel/mythtv-dvb_subtitles/releases/mythtv-dvb_subtitles-v1.0.patch
Attachments (1)
Change History (8)
comment:1 Changed 20 years ago by
comment:2 Changed 20 years ago by
Milestone: | 0.19 → unknown |
---|---|
Priority: | major → minor |
Seems to be lots of duplicate/unnecessary code in here (point/rect classes, bitstream reader). This really should go in avcodec, too.
comment:3 Changed 20 years ago by
I can do smaller cleanups like replacing duplicated code, but I don't have time to implement a decoder in ffmpeg because it needs to be in C and might need major changes.
Please just say if this does not have any change getting in without the ffmpeg decoder, in that case I should not bother cleaning it up as it works as is.
comment:4 Changed 20 years ago by
Owner: | changed from Isaac Richards to taylor |
---|
comment:5 Changed 19 years ago by
Milestone: | unknown → 0.19 |
---|
Just for information:
Ian Caulfield implemented a ffmpeg DVB sub decoder and I implemented a drawing code that uses it. It should not use any duplicated/unnecessary code.
Ian tries to get the decoder merged in ffmpeg, and I'll give the drawing code some beating, after which I'll try again to get it merged in MythTV. Looks good so far and I'm hopeful it could be merged for 0.19.
comment:6 Changed 19 years ago by
The decoder is now merged in ffmpeg. Please update the ffmpeg code and apply the attached patch which adds subtitle display code to MythTV.
Changed 19 years ago by
Attachment: | dvbsub_display_code.patch added |
---|
Displays subtitles decoded by the new ffmpeg DVB decoder.
Here's the updated version:
http://www.cs.tut.fi/~pjaaskel/mythtv-dvb_subtitles/releases/mythtv-dvb_subtitles-v1.1.patch